Issue 919443002: Disable tests that trip MOJO_DCHECK in release-with-dcheck builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 919443002: Disable tests that trip MOJO_DCHECK in release-with-dcheck builds (Closed)

Created:
5 years, 10 months ago by jamesr

Modified:
5 years, 10 months ago

Reviewers:
yzshen1, viettrungluu

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Disable tests that trip MOJO_DCHECK in release-with-dcheck builds These tests are designed to trip MOJO_DCHECKs. Guarding them with NDEBUG is not sufficient as we have a release-with-dcheck config that we use on the trybots. BUG=397317 R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/847492f4cfc15daf55fde59372a84c677689eb55

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	mojo/public/cpp/bindings/tests/bounds_checker_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	mojo/public/cpp/bindings/tests/buffer_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ggowan

On 2015/02/11 00:42:51, yzshen1 wrote: > lgtm Thanks for fixing this, James. Sorry I missed ...

5 years, 10 months ago (2015-02-11 00:54:09 UTC) #4

jamesr

Committed patchset #1 (id:1) manually as 847492f4cfc15daf55fde59372a84c677689eb55 (presubmit successful).

5 years, 10 months ago (2015-02-11 00:55:40 UTC) #5

Message was sent while issue was closed.

No worries.  These tests are pretty strange.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages