mojo/public/cpp/bindings/tests/bounds_checker_unittest.cc - Issue 919443002: Disable tests that trip MOJO_DCHECK in release-with-dcheck builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/bounds_checker_unittest.cc

Issue 919443002: Disable tests that trip MOJO_DCHECK in release-with-dcheck builds (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/tests/bounds_checker_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/bounds_checker_unittest.cc b/mojo/public/cpp/bindings/tests/bounds_checker_unittest.cc

index 1cd961873e5c0348e974d7073dbefd48bd8cb3a9..c1ec7b3fcc41b2d54e444ea904cbded2dd259533 100644

--- a/mojo/public/cpp/bindings/tests/bounds_checker_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/bounds_checker_unittest.cc

@@ -17,7 +17,7 @@ const void* ToPtr(uintptr_t ptr) {

return reinterpret_cast<const void*>(ptr);

}

-#ifdef NDEBUG

+#if defined(NDEBUG) && !defined(DCHECK_ALWAYS_ON)

TEST(BoundsCheckerTest, ConstructorRangeOverflow) {

{

// Test memory range overflow.

« no previous file with comments | « no previous file | mojo/public/cpp/bindings/tests/buffer_unittest.cc » ('j') | no next file with comments »