Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Side by Side Diff: mojo/public/cpp/bindings/tests/bounds_checker_unittest.cc

Issue 919443002: Disable tests that trip MOJO_DCHECK in release-with-dcheck builds (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | mojo/public/cpp/bindings/tests/buffer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits> 5 #include <limits>
6 6
7 #include "mojo/public/cpp/bindings/lib/bindings_serialization.h" 7 #include "mojo/public/cpp/bindings/lib/bindings_serialization.h"
8 #include "mojo/public/cpp/bindings/lib/bounds_checker.h" 8 #include "mojo/public/cpp/bindings/lib/bounds_checker.h"
9 #include "mojo/public/cpp/system/core.h" 9 #include "mojo/public/cpp/system/core.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 namespace mojo { 12 namespace mojo {
13 namespace test { 13 namespace test {
14 namespace { 14 namespace {
15 15
16 const void* ToPtr(uintptr_t ptr) { 16 const void* ToPtr(uintptr_t ptr) {
17 return reinterpret_cast<const void*>(ptr); 17 return reinterpret_cast<const void*>(ptr);
18 } 18 }
19 19
20 #ifdef NDEBUG 20 #if defined(NDEBUG) && !defined(DCHECK_ALWAYS_ON)
21 TEST(BoundsCheckerTest, ConstructorRangeOverflow) { 21 TEST(BoundsCheckerTest, ConstructorRangeOverflow) {
22 { 22 {
23 // Test memory range overflow. 23 // Test memory range overflow.
24 internal::BoundsChecker checker( 24 internal::BoundsChecker checker(
25 ToPtr(std::numeric_limits<uintptr_t>::max() - 3000), 5000, 0); 25 ToPtr(std::numeric_limits<uintptr_t>::max() - 3000), 5000, 0);
26 26
27 EXPECT_FALSE(checker.IsValidRange( 27 EXPECT_FALSE(checker.IsValidRange(
28 ToPtr(std::numeric_limits<uintptr_t>::max() - 3000), 1)); 28 ToPtr(std::numeric_limits<uintptr_t>::max() - 3000), 1));
29 EXPECT_FALSE(checker.ClaimMemory( 29 EXPECT_FALSE(checker.ClaimMemory(
30 ToPtr(std::numeric_limits<uintptr_t>::max() - 3000), 1)); 30 ToPtr(std::numeric_limits<uintptr_t>::max() - 3000), 1));
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 200
201 // This should be fine. 201 // This should be fine.
202 EXPECT_TRUE(checker.ClaimMemory( 202 EXPECT_TRUE(checker.ClaimMemory(
203 ToPtr(std::numeric_limits<uintptr_t>::max() - 750), 200)); 203 ToPtr(std::numeric_limits<uintptr_t>::max() - 750), 200));
204 } 204 }
205 } 205 }
206 206
207 } // namespace 207 } // namespace
208 } // namespace test 208 } // namespace test
209 } // namespace mojo 209 } // namespace mojo
OLDNEW
« no previous file with comments | « no previous file | mojo/public/cpp/bindings/tests/buffer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698