Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Side by Side Diff: mojo/public/cpp/bindings/tests/buffer_unittest.cc

Issue 919443002: Disable tests that trip MOJO_DCHECK in release-with-dcheck builds (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/public/cpp/bindings/tests/bounds_checker_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits> 5 #include <limits>
6 6
7 #include "mojo/public/cpp/bindings/lib/bindings_serialization.h" 7 #include "mojo/public/cpp/bindings/lib/bindings_serialization.h"
8 #include "mojo/public/cpp/bindings/lib/fixed_buffer.h" 8 #include "mojo/public/cpp/bindings/lib/fixed_buffer.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 EXPECT_EQ(0u, buf.size()); 59 EXPECT_EQ(0u, buf.size());
60 EXPECT_FALSE(buf.Leak()); 60 EXPECT_FALSE(buf.Leak());
61 } 61 }
62 62
63 // Since we called Leak, ptr is still writable after FixedBuffer went out of 63 // Since we called Leak, ptr is still writable after FixedBuffer went out of
64 // scope. 64 // scope.
65 memset(ptr, 1, 8); 65 memset(ptr, 1, 8);
66 free(buf_ptr); 66 free(buf_ptr);
67 } 67 }
68 68
69 #ifdef NDEBUG 69 #if defined(NDEBUG) && !defined(DCHECK_ALWAYS_ON)
70 TEST(FixedBufferTest, TooBig) { 70 TEST(FixedBufferTest, TooBig) {
71 internal::FixedBuffer buf(24); 71 internal::FixedBuffer buf(24);
72 72
73 // A little bit too large. 73 // A little bit too large.
74 EXPECT_EQ(reinterpret_cast<void*>(0), buf.Allocate(32)); 74 EXPECT_EQ(reinterpret_cast<void*>(0), buf.Allocate(32));
75 75
76 // Move the cursor forward. 76 // Move the cursor forward.
77 EXPECT_NE(reinterpret_cast<void*>(0), buf.Allocate(16)); 77 EXPECT_NE(reinterpret_cast<void*>(0), buf.Allocate(16));
78 78
79 // A lot too large. 79 // A lot too large.
80 EXPECT_EQ(reinterpret_cast<void*>(0), 80 EXPECT_EQ(reinterpret_cast<void*>(0),
81 buf.Allocate(std::numeric_limits<size_t>::max() - 1024u)); 81 buf.Allocate(std::numeric_limits<size_t>::max() - 1024u));
82 82
83 // A lot too large, leading to possible integer overflow. 83 // A lot too large, leading to possible integer overflow.
84 EXPECT_EQ(reinterpret_cast<void*>(0), 84 EXPECT_EQ(reinterpret_cast<void*>(0),
85 buf.Allocate(std::numeric_limits<size_t>::max() - 8u)); 85 buf.Allocate(std::numeric_limits<size_t>::max() - 8u));
86 } 86 }
87 #endif 87 #endif
88 88
89 } // namespace 89 } // namespace
90 } // namespace test 90 } // namespace test
91 } // namespace mojo 91 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/public/cpp/bindings/tests/bounds_checker_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698