Strip Interface class of most of its logic, make it all about Module exports

Strip Interface class of most of its logic, make it all about Module exports

This gets Variable and VariableProxy out of the business of worrying about
Interfaces.

At the same time, get rid of the notion of "module variables". In ES6, variables
that refer to modules will be simply be CONST bindings to module namespace
objects.

The only change in logic here is one more early error:
duplicate export names are now rejected.

BUG=v8:1569
LOG=n

Committed: https://crrev.com/522937cb494559d209bc53d8251458f33b4e9864
Cr-Commit-Position: refs/heads/master@{#26708}

[adamk, 2015-02-12 22:30:27]

adamk@chromium.org changed reviewers:
+ rossberg@chromium.org

[adamk, 2015-02-12 22:42:01]

Patchset #1 (id:1) has been deleted

[rossberg, 2015-02-16 12:46:43]

LGTM, modulo some nits.

It hurts to see the beautiful unification machinery gone...

https://codereview.chromium.org/918373002/diff/20001/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/918373002/diff/20001/src/globals.h#newcode756
src/globals.h:756: return (mode >= CONST && mode <= CONST) || mode ==
CONST_LEGACY;
mode == CONST ;)

https://codereview.chromium.org/918373002/diff/20001/src/interface.cc
File src/interface.cc (right):

https://codereview.chromium.org/918373002/diff/20001/src/interface.cc#newcode18
src/interface.cc:18: // Current nesting depth for debug output.
Since there are no more nested modules, this isn't really used anymore (current
stays 0 all the time).

https://codereview.chromium.org/918373002/diff/20001/src/interface.h
File src/interface.h (right):

https://codereview.chromium.org/918373002/diff/20001/src/interface.h#newcode19
src/interface.h:19: // TODO(adamk): Rename this to Module.
(Not sure Module would be the right name, it's more like a module descriptor.)

https://codereview.chromium.org/918373002/diff/20001/src/interface.h#newcode25
src/interface.h:25: static Interface* NewModule(Zone* zone) { return new (zone)
Interface(); }
Nit: now that there is only one form, rename to just New

[adamk, 2015-02-17 19:59:21]

New patchsets have been uploaded after l-g-t-m from rossberg@chromium.org

[adamk, 2015-02-17 19:59:34]

https://codereview.chromium.org/918373002/diff/20001/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/918373002/diff/20001/src/globals.h#newcode756
src/globals.h:756: return (mode >= CONST && mode <= CONST) || mode ==
CONST_LEGACY;
On 2015/02/16 12:46:43, rossberg wrote:
> mode == CONST ;)

Ha! I'd made this change in a bunch of different branches, and only got it wrong
once...fixed.

https://codereview.chromium.org/918373002/diff/20001/src/interface.cc
File src/interface.cc (right):

https://codereview.chromium.org/918373002/diff/20001/src/interface.cc#newcode18
src/interface.cc:18: // Current nesting depth for debug output.
On 2015/02/16 12:46:43, rossberg wrote:
> Since there are no more nested modules, this isn't really used anymore
(current
> stays 0 all the time).

I'd rather take care of this in a followup patch, the printing stuff needs to be
overhauled all over the place.

https://codereview.chromium.org/918373002/diff/20001/src/interface.h
File src/interface.h (right):

https://codereview.chromium.org/918373002/diff/20001/src/interface.h#newcode19
src/interface.h:19: // TODO(adamk): Rename this to Module.
On 2015/02/16 12:46:43, rossberg wrote:
> (Not sure Module would be the right name, it's more like a module descriptor.)

Made this TODO a little looser. I expect a rename will come very soon.

https://codereview.chromium.org/918373002/diff/20001/src/interface.h#newcode25
src/interface.h:25: static Interface* NewModule(Zone* zone) { return new (zone)
Interface(); }
On 2015/02/16 12:46:43, rossberg wrote:
> Nit: now that there is only one form, rename to just New

Done.

[adamk, 2015-02-17 20:28:32]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2015-02-17 20:29:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/918373002/80001

[commit-bot: I haz the power, 2015-02-17 20:51:30]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-02-17 20:51:47]

Patchset 4 (id:??) landed as
https://crrev.com/522937cb494559d209bc53d8251458f33b4e9864
Cr-Commit-Position: refs/heads/master@{#26708}