src/ia32/full-codegen-ia32.cc - Issue 918373002: Strip Interface class of most of its logic, make it all about Module exports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 918373002: Strip Interface class of most of its logic, make it all about Module exports (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Properly freeze interface at the end of ParseModule Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 4425045bd2ca1eab7b0b1c98339b63ffd9369211..e70ac4c378a431e3db6e3ba8859118c32fde1d2c 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -893,15 +893,16 @@ void FullCodeGenerator::VisitFunctionDeclaration(

void FullCodeGenerator::VisitModuleDeclaration(ModuleDeclaration* declaration) {

Variable* variable = declaration->proxy()->var();

+ Interface* interface = declaration->module()->interface();

DCHECK(variable->location() == Variable::CONTEXT);

- DCHECK(variable->interface()->IsFrozen());

+ DCHECK(interface->IsFrozen());

Comment cmnt(masm_, "[ ModuleDeclaration");

EmitDebugCheckDeclarationContext(variable);

// Load instance object.

__ LoadContext(eax, scope_->ContextChainLength(scope_->ScriptScope()));

- __ mov(eax, ContextOperand(eax, variable->interface()->Index()));

+ __ mov(eax, ContextOperand(eax, interface->Index()));

__ mov(eax, ContextOperand(eax, Context::EXTENSION_INDEX));

// Assign it.

« no previous file with comments | « src/hydrogen.cc ('k') | src/interface.h » ('j') | no next file with comments »