src/contexts.cc - Issue 918373002: Strip Interface class of most of its logic, make it all about Module exports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/contexts.cc

Issue 918373002: Strip Interface class of most of its logic, make it all about Module exports (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Properly freeze interface at the end of ParseModule Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/contexts.cc

diff --git a/src/contexts.cc b/src/contexts.cc

index 57490a118f5d9663ab55d6bb95a0ed4890ff3688..6537e2c3e260d5f8b1da53e04b0153e9c724d73e 100644

--- a/src/contexts.cc

+++ b/src/contexts.cc

@@ -173,10 +173,6 @@ static void GetAttributesAndBindingFlags(VariableMode mode,

? IMMUTABLE_CHECK_INITIALIZED_HARMONY

: IMMUTABLE_IS_INITIALIZED_HARMONY;

break;

- case MODULE:

- *attributes = READ_ONLY;

- *binding_flags = IMMUTABLE_IS_INITIALIZED_HARMONY;

- break;

case DYNAMIC:

case DYNAMIC_GLOBAL:

case DYNAMIC_LOCAL:

« no previous file with comments | « src/compiler/ast-loop-assignment-analyzer.cc ('k') | src/full-codegen.cc » ('j') | no next file with comments »