src/runtime/runtime-scopes.cc - Issue 918373002: Strip Interface class of most of its logic, make it all about Module exports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-scopes.cc

Issue 918373002: Strip Interface class of most of its logic, make it all about Module exports (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Properly freeze interface at the end of ParseModule Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-scopes.cc

diff --git a/src/runtime/runtime-scopes.cc b/src/runtime/runtime-scopes.cc

index 1062719a00a163962a245e20bb71e5fe455321f2..7eb2e0cfc1703940ec9e5a0231a17248b7df3d15 100644

--- a/src/runtime/runtime-scopes.cc

+++ b/src/runtime/runtime-scopes.cc

@@ -801,13 +801,6 @@ RUNTIME_FUNCTION(Runtime_DeclareModules) {

USE(result);

break;

}

- case MODULE: {

- Object* referenced_context = Context::cast(host_context)->get(index);

- Handle<JSModule> value(Context::cast(referenced_context)->module());

- JSObject::SetOwnPropertyIgnoreAttributes(module, name, value, FROZEN)

- .Assert();

- break;

- }

case INTERNAL:

case TEMPORARY:

case DYNAMIC:

« no previous file with comments | « src/rewriter.cc ('k') | src/scopeinfo.h » ('j') | no next file with comments »