Fix crash on second failed connect to a paired device

Fix crash on second failed connect to a paired device

When failing to connect to a previously-paired device, the profile would
not be cleared.  This sets adapter_ in RegisterProfile() so that it will
be set correctly for profile release later.

Also includes unit tests, adding a paired but non-connectable device.

BUG=455868
Committed: https://crrev.com/089a7dade5bfd6858fd88851d2171be816854845
Cr-Commit-Position: refs/heads/master@{#315394}

[Marie Janssen, 2015-02-06 22:34:01]

jamuraa@chromium.org changed reviewers:
+ armansito@chromium.org, keybuk@chromium.org, tbarzic@chromium.org

[tbarzic, 2015-02-06 22:59:01]

fyi, I tried the patch, and it seems to fix the crashes described in the bug

[armansito, 2015-02-07 00:29:55]

lgtm with nits

https://codereview.chromium.org/910433002/diff/1/chromeos/dbus/fake_bluetooth...
File chromeos/dbus/fake_bluetooth_device_client.cc (right):

https://codereview.chromium.org/910433002/diff/1/chromeos/dbus/fake_bluetooth...
chromeos/dbus/fake_bluetooth_device_client.cc:263:
&FakeBluetoothDeviceClient::OnPropertyChanged, base::Unretained(this),
nit: Formatting. Put second argument in its own line.

https://codereview.chromium.org/910433002/diff/1/chromeos/dbus/fake_bluetooth...
chromeos/dbus/fake_bluetooth_device_client.cc:403:
error_callback.Run(kNoResponseError, "unconnectable");
I think we use kNoResponseError for cases that are related to a D-Bus response
timeout. So maybe use a different error here.

[Marie Janssen, 2015-02-09 18:58:41]

https://codereview.chromium.org/910433002/diff/1/chromeos/dbus/fake_bluetooth...
File chromeos/dbus/fake_bluetooth_device_client.cc (right):

https://codereview.chromium.org/910433002/diff/1/chromeos/dbus/fake_bluetooth...
chromeos/dbus/fake_bluetooth_device_client.cc:263:
&FakeBluetoothDeviceClient::OnPropertyChanged, base::Unretained(this),
On 2015/02/07 00:29:55, armansito wrote:
> nit: Formatting. Put second argument in its own line.

git cl format chromeos disagrees, and chromeos/ requires clang-formatting.

https://codereview.chromium.org/910433002/diff/1/chromeos/dbus/fake_bluetooth...
chromeos/dbus/fake_bluetooth_device_client.cc:403:
error_callback.Run(kNoResponseError, "unconnectable");
On 2015/02/07 00:29:55, armansito wrote:
> I think we use kNoResponseError for cases that are related to a D-Bus response
> timeout. So maybe use a different error here.

Done. Using kErrorFailed instead.

[Marie Janssen, 2015-02-09 18:58:43]

New patchsets have been uploaded after l-g-t-m from armansito@chromium.org

[Marie Janssen, 2015-02-09 18:58:53]

The CQ bit was checked by jamuraa@chromium.org

[commit-bot: I haz the power, 2015-02-09 18:59:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/910433002/20001

[Marie Janssen, 2015-02-09 20:13:24]

The CQ bit was checked by jamuraa@chromium.org

[commit-bot: I haz the power, 2015-02-09 20:14:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/910433002/40001

[commit-bot: I haz the power, 2015-02-09 20:20:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-09 20:20:28]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Marie Janssen, 2015-02-09 20:30:01]

jamuraa@chromium.org changed reviewers:
+ rtenneti@google.com

[Marie Janssen, 2015-02-09 20:30:02]

Adding rtenneti for OWNERS check on  chromeos_metrics_provider_unittest.cc

[armansito, 2015-02-09 20:35:22]

https://codereview.chromium.org/910433002/diff/1/chromeos/dbus/fake_bluetooth...
File chromeos/dbus/fake_bluetooth_device_client.cc (right):

https://codereview.chromium.org/910433002/diff/1/chromeos/dbus/fake_bluetooth...
chromeos/dbus/fake_bluetooth_device_client.cc:263:
&FakeBluetoothDeviceClient::OnPropertyChanged, base::Unretained(this),
On 2015/02/09 18:58:41, Michael Janssen wrote:
> On 2015/02/07 00:29:55, armansito wrote:
> > nit: Formatting. Put second argument in its own line.
> 
> git cl format chromeos disagrees, and chromeos/ requires clang-formatting.

I disagree with git cl format here, it doesn't always produce the best
formatting (especially for unit tests with gmock).

[ramant (doing other things), 2015-02-09 20:51:45]

rtenneti@chromium.org changed reviewers:
+ rtenneti@chromium.org

[ramant (doing other things), 2015-02-09 20:51:46]

LGTM for chrome/browser/metrics/chromeos_metrics_provider_unittest.cc

[Marie Janssen, 2015-02-09 21:08:58]

The CQ bit was checked by jamuraa@chromium.org

[commit-bot: I haz the power, 2015-02-09 21:10:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/910433002/40001

[commit-bot: I haz the power, 2015-02-09 21:14:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-09 21:15:08]

Patchset 3 (id:??) landed as
https://crrev.com/089a7dade5bfd6858fd88851d2171be816854845
Cr-Commit-Position: refs/heads/master@{#315394}