Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: device/bluetooth/bluetooth_socket_chromeos_unittest.cc

Issue 910433002: Fix crash on second failed connect to a paired device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bugfix unit tests Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/bluetooth/bluetooth_socket_chromeos.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/bluetooth_socket_chromeos_unittest.cc
diff --git a/device/bluetooth/bluetooth_socket_chromeos_unittest.cc b/device/bluetooth/bluetooth_socket_chromeos_unittest.cc
index 79d43ae8bb5f25d5cd67d181ba018614a8c4d18e..8381cdd0b986dc8fe05087c02047f18d4ea06137 100644
--- a/device/bluetooth/bluetooth_socket_chromeos_unittest.cc
+++ b/device/bluetooth/bluetooth_socket_chromeos_unittest.cc
@@ -528,4 +528,34 @@ TEST_F(BluetoothSocketChromeOSTest, ListenAcrossAdapterRestart) {
EXPECT_EQ(1U, success_callback_count_);
}
+TEST_F(BluetoothSocketChromeOSTest, PairedConnectFails) {
+ BluetoothDevice* device = adapter_->GetDevice(
+ FakeBluetoothDeviceClient::kPairedUnconnectableDeviceAddress);
+ ASSERT_TRUE(device != NULL);
+
+ device->ConnectToService(
+ BluetoothUUID(FakeBluetoothProfileManagerClient::kRfcommUuid),
+ base::Bind(&BluetoothSocketChromeOSTest::ConnectToServiceSuccessCallback,
+ base::Unretained(this)),
+ base::Bind(&BluetoothSocketChromeOSTest::ErrorCallback,
+ base::Unretained(this)));
+ message_loop_.Run();
+
+ EXPECT_EQ(0U, success_callback_count_);
+ EXPECT_EQ(1U, error_callback_count_);
+ EXPECT_TRUE(last_socket_.get() == NULL);
+
+ device->ConnectToService(
+ BluetoothUUID(FakeBluetoothProfileManagerClient::kRfcommUuid),
+ base::Bind(&BluetoothSocketChromeOSTest::ConnectToServiceSuccessCallback,
+ base::Unretained(this)),
+ base::Bind(&BluetoothSocketChromeOSTest::ErrorCallback,
+ base::Unretained(this)));
+ message_loop_.Run();
+
+ EXPECT_EQ(0U, success_callback_count_);
+ EXPECT_EQ(2U, error_callback_count_);
+ EXPECT_TRUE(last_socket_.get() == NULL);
+}
+
} // namespace chromeos
« no previous file with comments | « device/bluetooth/bluetooth_socket_chromeos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698