Fix crash on second failed connect to a paired device

chrome/browser/metrics/chromeos_metrics_provider_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/chromeos_metrics_provider.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "chrome/browser/chromeos/login/users/fake_chrome_user_manager.h"
@@ skipping 177 matching lines @@
   provider.ProvideSystemProfileMetrics(&system_profile);
 
   EXPECT_TRUE(system_profile.has_hardware());
   EXPECT_TRUE(system_profile.hardware().has_bluetooth());
 
   EXPECT_TRUE(system_profile.hardware().bluetooth().is_present());
   EXPECT_TRUE(system_profile.hardware().bluetooth().is_enabled());
 }
 
 TEST_F(ChromeOSMetricsProviderTest, BluetoothPairedDevices) {
-  // The fake bluetooth adapter class already claims to be paired with one
-  // device when initialized. Add a second and third fake device to it so we
+  // The fake bluetooth adapter class already claims to be paired with two
+  // device when initialized. Add a third and fourth fake device to it so we
   // can test the cases where a device is not paired (LE device, generally)
   // and a device that does not have Device ID information.
   fake_bluetooth_device_client_->CreateDevice(
       dbus::ObjectPath(FakeBluetoothAdapterClient::kAdapterPath),
       dbus::ObjectPath(FakeBluetoothDeviceClient::kRequestPinCodePath));
 
   fake_bluetooth_device_client_->CreateDevice(
       dbus::ObjectPath(FakeBluetoothAdapterClient::kAdapterPath),
       dbus::ObjectPath(FakeBluetoothDeviceClient::kConfirmPasskeyPath));
 
   FakeBluetoothDeviceClient::Properties* properties =
       fake_bluetooth_device_client_->GetProperties(
           dbus::ObjectPath(FakeBluetoothDeviceClient::kConfirmPasskeyPath));
   properties->paired.ReplaceValue(true);
 
   ChromeOSMetricsProvider provider;
   provider.OnDidCreateMetricsLog();
   metrics::SystemProfileProto system_profile;
   provider.ProvideSystemProfileMetrics(&system_profile);
 
   ASSERT_TRUE(system_profile.has_hardware());
   ASSERT_TRUE(system_profile.hardware().has_bluetooth());
 
-  // Only two of the devices should appear.
-  EXPECT_EQ(2, system_profile.hardware().bluetooth().paired_device_size());
+  // Only three of the devices should appear.
+  EXPECT_EQ(3, system_profile.hardware().bluetooth().paired_device_size());
 
   typedef metrics::SystemProfileProto::Hardware::Bluetooth::PairedDevice
       PairedDevice;
 
   // First device should match the Paired Device object, complete with
   // parsed Device ID information.
   PairedDevice device1 = system_profile.hardware().bluetooth().paired_device(0);
 
   EXPECT_EQ(FakeBluetoothDeviceClient::kPairedDeviceClass,
             device1.bluetooth_class());
   EXPECT_EQ(PairedDevice::DEVICE_COMPUTER, device1.type());
   EXPECT_EQ(0x001122U, device1.vendor_prefix());
   EXPECT_EQ(PairedDevice::VENDOR_ID_USB, device1.vendor_id_source());
   EXPECT_EQ(0x05ACU, device1.vendor_id());
   EXPECT_EQ(0x030DU, device1.product_id());
   EXPECT_EQ(0x0306U, device1.device_id());
 
-  // Second device should match the Confirm Passkey object, this has
+  // Third device should match the Confirm Passkey object, this has
   // no Device ID information.
   PairedDevice device2 = system_profile.hardware().bluetooth().paired_device(1);
 
   EXPECT_EQ(FakeBluetoothDeviceClient::kConfirmPasskeyClass,
             device2.bluetooth_class());
   EXPECT_EQ(PairedDevice::DEVICE_PHONE, device2.type());
   EXPECT_EQ(0x207D74U, device2.vendor_prefix());
   EXPECT_EQ(PairedDevice::VENDOR_ID_UNKNOWN, device2.vendor_id_source());
 }