Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Unified Diff: chrome/browser/metrics/chromeos_metrics_provider_unittest.cc

Issue 910433002: Fix crash on second failed connect to a paired device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bugfix unit tests Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/dbus/fake_bluetooth_device_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/chromeos_metrics_provider_unittest.cc
diff --git a/chrome/browser/metrics/chromeos_metrics_provider_unittest.cc b/chrome/browser/metrics/chromeos_metrics_provider_unittest.cc
index 897075778a737b59aa7b7df3efa27d7bbb8ae653..f47b5d90a7cad4341b3721c4e201c88584ea57b9 100644
--- a/chrome/browser/metrics/chromeos_metrics_provider_unittest.cc
+++ b/chrome/browser/metrics/chromeos_metrics_provider_unittest.cc
@@ -195,8 +195,8 @@ TEST_F(ChromeOSMetricsProviderTest, BluetoothHardwareEnabled) {
}
TEST_F(ChromeOSMetricsProviderTest, BluetoothPairedDevices) {
- // The fake bluetooth adapter class already claims to be paired with one
- // device when initialized. Add a second and third fake device to it so we
+ // The fake bluetooth adapter class already claims to be paired with two
+ // device when initialized. Add a third and fourth fake device to it so we
// can test the cases where a device is not paired (LE device, generally)
// and a device that does not have Device ID information.
fake_bluetooth_device_client_->CreateDevice(
@@ -220,8 +220,8 @@ TEST_F(ChromeOSMetricsProviderTest, BluetoothPairedDevices) {
ASSERT_TRUE(system_profile.has_hardware());
ASSERT_TRUE(system_profile.hardware().has_bluetooth());
- // Only two of the devices should appear.
- EXPECT_EQ(2, system_profile.hardware().bluetooth().paired_device_size());
+ // Only three of the devices should appear.
+ EXPECT_EQ(3, system_profile.hardware().bluetooth().paired_device_size());
typedef metrics::SystemProfileProto::Hardware::Bluetooth::PairedDevice
PairedDevice;
@@ -239,7 +239,7 @@ TEST_F(ChromeOSMetricsProviderTest, BluetoothPairedDevices) {
EXPECT_EQ(0x030DU, device1.product_id());
EXPECT_EQ(0x0306U, device1.device_id());
- // Second device should match the Confirm Passkey object, this has
+ // Third device should match the Confirm Passkey object, this has
// no Device ID information.
PairedDevice device2 = system_profile.hardware().bluetooth().paired_device(1);
« no previous file with comments | « no previous file | chromeos/dbus/fake_bluetooth_device_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698