Issue 902563002: Fix assertion in full codegen for holed 'this'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 902563002: Fix assertion in full codegen for holed 'this'. (Closed)

Created:
5 years, 10 months ago by Dmitry Lomov (no reviews)

Modified:
5 years, 10 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Fix assertion in full codegen for holed 'this'. R=rossberg@chromium.org BUG=chromium:455141 LOG=N Committed: https://crrev.com/275e088abec213aa0be3eef748926e4be2c5c79f Cr-Commit-Position: refs/heads/master@{#26423}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -10 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/arm64/full-codegen-arm64.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
A +	test/mjsunit/harmony/regress/regress-455141.js	View	1 chunk	+9 lines, -6 lines	0 comments	Download

Total messages: 6 (1 generated)

Dmitry Lomov (no reviews)

PTAL (the bug was that shared_info may not be yet allocated with no_lazy). Please cq ...

5 years, 10 months ago (2015-02-04 11:48:59 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902563002/1

5 years, 10 months ago (2015-02-04 11:52:55 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-04 12:14:46 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/275e088abec213aa0be3eef748926e4be2c5c79f
Cr-Commit-Position: refs/heads/master@{#26423}