src/ia32/full-codegen-ia32.cc - Issue 902563002: Fix assertion in full codegen for holed 'this'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 902563002: Fix assertion in full codegen for holed 'this'. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 777ec6891f76d340a02e1321245e977b4b4bf51e..eb4c1bc31f259666199edad12e4de1e3727aed2c 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -1462,7 +1462,8 @@ void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy) {

if (var->scope()->DeclarationScope() != scope()->DeclarationScope()) {

skip_init_check = false;

} else if (var->is_this()) {

- CHECK((info_->shared_info()->kind() & kSubclassConstructor) != 0);

+ CHECK(info_->function() != nullptr &&

+ (info_->function()->kind() & kSubclassConstructor) != 0);

// TODO(dslomov): implement 'this' hole check elimination.

skip_init_check = false;

} else {

« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »