Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 902563002: Fix assertion in full codegen for holed 'this'. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1521 matching lines...) Expand 10 before | Expand all | Expand 10 after
1532 // 1532 //
1533 // The condition on the declaration scopes is a conservative check for 1533 // The condition on the declaration scopes is a conservative check for
1534 // nested functions that access a binding and are called before the 1534 // nested functions that access a binding and are called before the
1535 // binding is initialized: 1535 // binding is initialized:
1536 // function() { f(); let x = 1; function f() { x = 2; } } 1536 // function() { f(); let x = 1; function f() { x = 2; } }
1537 // 1537 //
1538 bool skip_init_check; 1538 bool skip_init_check;
1539 if (var->scope()->DeclarationScope() != scope()->DeclarationScope()) { 1539 if (var->scope()->DeclarationScope() != scope()->DeclarationScope()) {
1540 skip_init_check = false; 1540 skip_init_check = false;
1541 } else if (var->is_this()) { 1541 } else if (var->is_this()) {
1542 CHECK((info_->shared_info()->kind() & kSubclassConstructor) != 0); 1542 CHECK(info_->function() != nullptr &&
1543 (info_->function()->kind() & kSubclassConstructor) != 0);
1543 // TODO(dslomov): implement 'this' hole check elimination. 1544 // TODO(dslomov): implement 'this' hole check elimination.
1544 skip_init_check = false; 1545 skip_init_check = false;
1545 } else { 1546 } else {
1546 // Check that we always have valid source position. 1547 // Check that we always have valid source position.
1547 DCHECK(var->initializer_position() != RelocInfo::kNoPosition); 1548 DCHECK(var->initializer_position() != RelocInfo::kNoPosition);
1548 DCHECK(proxy->position() != RelocInfo::kNoPosition); 1549 DCHECK(proxy->position() != RelocInfo::kNoPosition);
1549 skip_init_check = var->mode() != CONST_LEGACY && 1550 skip_init_check = var->mode() != CONST_LEGACY &&
1550 var->initializer_position() < proxy->position(); 1551 var->initializer_position() < proxy->position();
1551 } 1552 }
1552 1553
(...skipping 3868 matching lines...) Expand 10 before | Expand all | Expand 10 after
5421 5422
5422 DCHECK(interrupt_address == 5423 DCHECK(interrupt_address ==
5423 isolate->builtins()->OsrAfterStackCheck()->entry()); 5424 isolate->builtins()->OsrAfterStackCheck()->entry());
5424 return OSR_AFTER_STACK_CHECK; 5425 return OSR_AFTER_STACK_CHECK;
5425 } 5426 }
5426 5427
5427 5428
5428 } } // namespace v8::internal 5429 } } // namespace v8::internal
5429 5430
5430 #endif // V8_TARGET_ARCH_ARM 5431 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698