Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: src/arm64/full-codegen-arm64.cc

Issue 902563002: Fix assertion in full codegen for holed 'this'. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1501 matching lines...) Expand 10 before | Expand all | Expand 10 after
1512 // 1512 //
1513 // The condition on the declaration scopes is a conservative check for 1513 // The condition on the declaration scopes is a conservative check for
1514 // nested functions that access a binding and are called before the 1514 // nested functions that access a binding and are called before the
1515 // binding is initialized: 1515 // binding is initialized:
1516 // function() { f(); let x = 1; function f() { x = 2; } } 1516 // function() { f(); let x = 1; function f() { x = 2; } }
1517 // 1517 //
1518 bool skip_init_check; 1518 bool skip_init_check;
1519 if (var->scope()->DeclarationScope() != scope()->DeclarationScope()) { 1519 if (var->scope()->DeclarationScope() != scope()->DeclarationScope()) {
1520 skip_init_check = false; 1520 skip_init_check = false;
1521 } else if (var->is_this()) { 1521 } else if (var->is_this()) {
1522 CHECK((info_->shared_info()->kind() & kSubclassConstructor) != 0); 1522 CHECK(info_->function() != nullptr &&
1523 (info_->function()->kind() & kSubclassConstructor) != 0);
1523 // TODO(dslomov): implement 'this' hole check elimination. 1524 // TODO(dslomov): implement 'this' hole check elimination.
1524 skip_init_check = false; 1525 skip_init_check = false;
1525 } else { 1526 } else {
1526 // Check that we always have valid source position. 1527 // Check that we always have valid source position.
1527 DCHECK(var->initializer_position() != RelocInfo::kNoPosition); 1528 DCHECK(var->initializer_position() != RelocInfo::kNoPosition);
1528 DCHECK(proxy->position() != RelocInfo::kNoPosition); 1529 DCHECK(proxy->position() != RelocInfo::kNoPosition);
1529 skip_init_check = var->mode() != CONST_LEGACY && 1530 skip_init_check = var->mode() != CONST_LEGACY &&
1530 var->initializer_position() < proxy->position(); 1531 var->initializer_position() < proxy->position();
1531 } 1532 }
1532 1533
(...skipping 3867 matching lines...) Expand 10 before | Expand all | Expand 10 after
5400 return previous_; 5401 return previous_;
5401 } 5402 }
5402 5403
5403 5404
5404 #undef __ 5405 #undef __
5405 5406
5406 5407
5407 } } // namespace v8::internal 5408 } } // namespace v8::internal
5408 5409
5409 #endif // V8_TARGET_ARCH_ARM64 5410 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698