Issue 90113002: fix custom elements that extend tags like "section"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 90113002: fix custom elements that extend tags like "section" (Closed)

Created:
7 years ago by Jennifer Messerly

Modified:
7 years ago

Reviewers:
sra1, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

fix custom elements that extend tags like "section" Some tags don't have their own HTMLElement subclass (because they lack unique DOM properties), but it should still be possible to extend them. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=30833

Patch Set 1 #

Total comments: 1

Patch Set 2 : revert whitespace changes #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -11 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/html/custom/constructor_calls_created_synchronously_test.dart	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	tools/dom/src/dart2js_CustomElementSupport.dart	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

https://codereview.chromium.org/90113002/diff/1/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (right): https://codereview.chromium.org/90113002/diff/1/sdk/lib/html/dartium/html_dartium.dart#newcode27948 sdk/lib/html/dartium/html_dartium.dart:27948: + if ((blob_OR_source_OR_stream is MediaStream || blob_OR_source_OR_stream == null)) ...

7 years ago (2013-11-27 00:51:27 UTC) #1

Jennifer Messerly

7 years ago (2013-12-03 23:47:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r30833 (presubmit successful).

Expand Messages | Collapse Messages