Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: tools/dom/src/dart2js_CustomElementSupport.dart

Issue 90113002: fix custom elements that extend tags like "section" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: revert whitespace changes Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/html/custom/constructor_calls_created_synchronously_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/src/dart2js_CustomElementSupport.dart
diff --git a/tools/dom/src/dart2js_CustomElementSupport.dart b/tools/dom/src/dart2js_CustomElementSupport.dart
index f38bae15be20a58ff8fbd7e61bf74a8e8ed87ce9..665cd5e26e61f0529f0948a28241932b37325d68 100644
--- a/tools/dom/src/dart2js_CustomElementSupport.dart
+++ b/tools/dom/src/dart2js_CustomElementSupport.dart
@@ -113,10 +113,8 @@ void _registerCustomElement(context, document, String tag, Type type,
var options = JS('=Object', '{prototype: #}', proto);
- if (baseClassName != 'HTMLElement') {
- if (extendsTagName != null) {
- JS('=Object', '#.extends = #', options, extendsTagName);
- }
+ if (extendsTagName != null) {
+ JS('=Object', '#.extends = #', options, extendsTagName);
}
JS('void', '#.register(#, #)', document, tag, options);
« no previous file with comments | « tests/html/custom/constructor_calls_created_synchronously_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698