sdk/lib/html/dart2js/html_dart2js.dart - Issue 90113002: fix custom elements that extend tags like "section"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 90113002: fix custom elements that extend tags like "section" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: revert whitespace changes Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: sdk/lib/html/dart2js/html_dart2js.dart

diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart

index 944d6e6dc1088a34428e465730c71cb21b44465b..a5c54438f94e7c2f5dcf91bb9d0c25675f56097b 100644

--- a/sdk/lib/html/dart2js/html_dart2js.dart

+++ b/sdk/lib/html/dart2js/html_dart2js.dart

@@ -34418,10 +34418,8 @@ void _registerCustomElement(context, document, String tag, Type type,

var options = JS('=Object', '{prototype: #}', proto);

- if (baseClassName != 'HTMLElement') {

- if (extendsTagName != null) {

- JS('=Object', '#.extends = #', options, extendsTagName);

- }

+ if (extendsTagName != null) {

+ JS('=Object', '#.extends = #', options, extendsTagName);

}

JS('void', '#.register(#, #)', document, tag, options);

« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »