Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 901083004: Contribution of PowerPC port (continuation of 422063005) - PPC dir update (Closed)

Created:
5 years, 10 months ago by michael_dawson
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Contribution of PowerPC port (continuation of 422063005) - PPC dir update Contribution of PowerPC port (continuation of 422063005, 817143002 and 866843003) This patch brings the ppc directories up to date with our repo. We have removed 5 individual optimizations which require changes in both the ppc and common directories so they can be more easily reviewed on their own in subsequent patches. Subsequent patches will cover: - individual optimizations for PPC (5) - remaining AIX changes not resolved by 4.8 compiler (4.8 is only recently available for AIX) - incremental updates required to ppc directories due to platform specific changes made in google repos while we complete the above steps. With the update there are still some timeouts seen when run in simulated mode which may be a result of the missing optimizations. Once we have the optimizations in we will review the simulation results and address/exclude tests as necessary so that the simulated runs are clean. new file: src/compiler/ppc/code-generator-ppc.cc new file: src/compiler/ppc/instruction-codes-ppc.h new file: src/compiler/ppc/instruction-selector-ppc.cc new file: src/compiler/ppc/linkage-ppc.cc modified: src/ic/ppc/handler-compiler-ppc.cc modified: src/ic/ppc/ic-compiler-ppc.cc modified: src/ic/ppc/ic-ppc.cc modified: src/ic/ppc/stub-cache-ppc.cc modified: src/ppc/assembler-ppc.cc modified: src/ppc/assembler-ppc.h modified: src/ppc/builtins-ppc.cc modified: src/ppc/code-stubs-ppc.cc modified: src/ppc/code-stubs-ppc.h modified: src/ppc/codegen-ppc.cc modified: src/ppc/constants-ppc.h modified: src/ppc/deoptimizer-ppc.cc modified: src/ppc/disasm-ppc.cc modified: src/ppc/full-codegen-ppc.cc modified: src/ppc/interface-descriptors-ppc.cc modified: src/ppc/lithium-codegen-ppc.cc modified: src/ppc/lithium-codegen-ppc.h modified: src/ppc/lithium-ppc.cc modified: src/ppc/lithium-ppc.h modified: src/ppc/macro-assembler-ppc.cc modified: src/ppc/macro-assembler-ppc.h modified: src/ppc/regexp-macro-assembler-ppc.cc modified: src/ppc/regexp-macro-assembler-ppc.h modified: src/ppc/simulator-ppc.cc modified: src/ppc/simulator-ppc.h new file: test/unittests/compiler/ppc/instruction-selector-ppc-unittest.cc R=danno@chromium.org, svenpanne@chromium.org BUG= Committed: https://crrev.com/308d913a92fa2801ad768553aa650227206004c3 Cr-Commit-Position: refs/heads/master@{#26471}

Patch Set 1 #

Patch Set 2 : Contribution of PowerPC port (continuation of 422063005) - PPC dir update -comments and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5349 lines, -1569 lines) Patch
M src/compiler/mips64/code-generator-mips64.cc View 1 1 chunk +0 lines, -18 lines 0 comments Download
A src/compiler/ppc/code-generator-ppc.cc View 1 1 chunk +1363 lines, -0 lines 0 comments Download
A src/compiler/ppc/instruction-codes-ppc.h View 1 1 chunk +125 lines, -0 lines 0 comments Download
A src/compiler/ppc/instruction-selector-ppc.cc View 1 1 chunk +1383 lines, -0 lines 0 comments Download
A + src/compiler/ppc/linkage-ppc.cc View 1 chunk +12 lines, -10 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 23 chunks +153 lines, -100 lines 0 comments Download
M src/ic/ppc/ic-compiler-ppc.cc View 4 chunks +16 lines, -13 lines 0 comments Download
M src/ic/ppc/ic-ppc.cc View 12 chunks +100 lines, -130 lines 0 comments Download
M src/ic/ppc/stub-cache-ppc.cc View 7 chunks +40 lines, -38 lines 0 comments Download
M src/ppc/assembler-ppc.h View 1 12 chunks +66 lines, -20 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 1 19 chunks +121 lines, -51 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 7 chunks +117 lines, -34 lines 0 comments Download
M src/ppc/code-stubs-ppc.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 36 chunks +558 lines, -168 lines 0 comments Download
M src/ppc/codegen-ppc.cc View 12 chunks +39 lines, -52 lines 0 comments Download
M src/ppc/constants-ppc.h View 1 6 chunks +20 lines, -34 lines 0 comments Download
M src/ppc/deoptimizer-ppc.cc View 2 chunks +10 lines, -1 line 0 comments Download
M src/ppc/disasm-ppc.cc View 9 chunks +78 lines, -67 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 38 chunks +204 lines, -118 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 4 chunks +53 lines, -1 line 0 comments Download
M src/ppc/lithium-codegen-ppc.h View 1 3 chunks +5 lines, -7 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 60 chunks +337 lines, -225 lines 0 comments Download
M src/ppc/lithium-ppc.h View 8 chunks +24 lines, -11 lines 0 comments Download
M src/ppc/lithium-ppc.cc View 11 chunks +50 lines, -44 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 12 chunks +51 lines, -38 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 25 chunks +150 lines, -226 lines 0 comments Download
M src/ppc/regexp-macro-assembler-ppc.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ppc/regexp-macro-assembler-ppc.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/ppc/simulator-ppc.h View 3 chunks +16 lines, -4 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 31 chunks +236 lines, -149 lines 0 comments Download
A test/unittests/compiler/ppc/instruction-selector-ppc-unittest.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
michael_dawson
5 years, 10 months ago (2015-02-05 02:52:18 UTC) #1
Sven Panne
LGTM (basically rubber-stamped), but it needs a rebase. Feel free to tick the CQ box ...
5 years, 10 months ago (2015-02-05 07:54:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901083004/20001
5 years, 10 months ago (2015-02-05 18:39:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 19:02:00 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 19:02:17 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/308d913a92fa2801ad768553aa650227206004c3
Cr-Commit-Position: refs/heads/master@{#26471}

Powered by Google App Engine
This is Rietveld 408576698