Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 900543003: DevTools: do not abuse inspector controller for the front-end side plumbing. (Closed)

Created:
5 years, 10 months ago by pfeldman
Modified:
5 years, 10 months ago
Reviewers:
dgozman, yurys
CC:
blink-reviews, tzik, apavlov+blink_chromium.org, aandrey+blink_chromium.org, caseq+blink_chromium.org, arv+blink, malch+blink_chromium.org, yurys+blink_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, nhiroki, eustas+blink_chromium.org, paulirish+reviews_chromium.org, lushnikov+blink_chromium.org, Nate Chapin, tyoshino+watch_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive, sergeyv+blink_chromium.org, kinuko+fileapi
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: do not abuse inspector controller for the front-end side plumbing. BUG=451004 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189491

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review comments addressed. #

Patch Set 3 : Fixed initializer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -149 lines) Patch
M Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/DevToolsHost.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/inspector/DevToolsHost.cpp View 1 6 chunks +16 lines, -21 lines 0 comments Download
M Source/core/inspector/InspectorClient.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorController.h View 4 chunks +0 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorController.cpp View 6 chunks +0 lines, -31 lines 0 comments Download
M Source/core/inspector/InspectorFrontendClient.h View 1 1 chunk +7 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorInspectorAgent.h View 4 chunks +0 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorInspectorAgent.cpp View 2 chunks +0 lines, -23 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/filesystem/DevToolsHostFileSystem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 2 chunks +5 lines, -0 lines 0 comments Download
M Source/web/InspectorClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/InspectorClientImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/WebDevToolsFrontendImpl.h View 1 1 chunk +13 lines, -9 lines 0 comments Download
M Source/web/WebDevToolsFrontendImpl.cpp View 1 4 chunks +43 lines, -26 lines 0 comments Download
M Source/web/WebLocalFrameImpl.h View 3 chunks +7 lines, -0 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebDevToolsFrontend.h View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
pfeldman
5 years, 10 months ago (2015-02-03 19:04:17 UTC) #2
dgozman
lgtm modulo contextMenu https://codereview.chromium.org/900543003/diff/1/Source/core/inspector/DevToolsHost.cpp File Source/core/inspector/DevToolsHost.cpp (left): https://codereview.chromium.org/900543003/diff/1/Source/core/inspector/DevToolsHost.cpp#oldcode226 Source/core/inspector/DevToolsHost.cpp:226: page->inspectorController().showContextMenu(x * zoom, y * zoom, ...
5 years, 10 months ago (2015-02-03 20:38:08 UTC) #3
pfeldman
https://codereview.chromium.org/900543003/diff/1/Source/core/inspector/DevToolsHost.cpp File Source/core/inspector/DevToolsHost.cpp (left): https://codereview.chromium.org/900543003/diff/1/Source/core/inspector/DevToolsHost.cpp#oldcode226 Source/core/inspector/DevToolsHost.cpp:226: page->inspectorController().showContextMenu(x * zoom, y * zoom, menuProvider); On 2015/02/03 ...
5 years, 10 months ago (2015-02-04 06:50:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900543003/20001
5 years, 10 months ago (2015-02-04 06:50:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/45170) win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/49194)
5 years, 10 months ago (2015-02-04 07:18:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900543003/40001
5 years, 10 months ago (2015-02-04 08:15:35 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/49208)
5 years, 10 months ago (2015-02-04 10:03:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900543003/40001
5 years, 10 months ago (2015-02-04 10:16:35 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 12:08:26 UTC) #16
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189491

Powered by Google App Engine
This is Rietveld 408576698