Source/web/FrameLoaderClientImpl.cpp - Issue 900543003: DevTools: do not abuse inspector controller for the front-end side plumbing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 900543003: DevTools: do not abuse inspector controller for the front-end side plumbing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed initializer. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/FrameLoaderClientImpl.cpp

diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp

index 1cbbdb1f7cf1c1f15bcb5e62c6b34973dc0c330e..e63ced73b452873d7737768e36fcf2e11c652b92 100644

--- a/Source/web/FrameLoaderClientImpl.cpp

+++ b/Source/web/FrameLoaderClientImpl.cpp

@@ -89,6 +89,7 @@

#include "web/PluginPlaceholderImpl.h"

#include "web/SharedWorkerRepositoryClientImpl.h"

#include "web/WebDataSourceImpl.h"

+#include "web/WebDevToolsFrontendImpl.h"

#include "web/WebLocalFrameImpl.h"

#include "web/WebPluginContainerImpl.h"

#include "web/WebPluginLoadObserver.h"

@@ -131,6 +132,10 @@ void FrameLoaderClientImpl::dispatchDidClearWindowObjectInMainWorld()

DOMWindowStorageController::from(*document);

}

+ // FIXME: when extensions go out of process, this whole concept stops working.

+ WebDevToolsFrontendImpl* devToolsFrontend = m_webFrame->top()->isWebLocalFrame() ? toWebLocalFrameImpl(m_webFrame->top())->devToolsFrontend() : nullptr;

+ if (devToolsFrontend)

+ devToolsFrontend->didClearWindowObject(m_webFrame);

}

void FrameLoaderClientImpl::documentElementAvailable()

« no previous file with comments | « Source/modules/filesystem/DevToolsHostFileSystem.cpp ('k') | Source/web/InspectorClientImpl.h » ('j') | no next file with comments »