Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: Source/core/inspector/InspectorController.cpp

Issue 900543003: DevTools: do not abuse inspector controller for the front-end side plumbing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed initializer. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorController.h ('k') | Source/core/inspector/InspectorFrontendClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorController.cpp
diff --git a/Source/core/inspector/InspectorController.cpp b/Source/core/inspector/InspectorController.cpp
index 9e609e8258a8f8406fb2758e09faec3d74c7479c..56812a09e40e4ddd2354c31a50603bcce6d4d331 100644
--- a/Source/core/inspector/InspectorController.cpp
+++ b/Source/core/inspector/InspectorController.cpp
@@ -48,7 +48,6 @@
#include "core/inspector/InspectorDOMDebuggerAgent.h"
#include "core/inspector/InspectorDOMStorageAgent.h"
#include "core/inspector/InspectorDebuggerAgent.h"
-#include "core/inspector/InspectorFrontendClient.h"
#include "core/inspector/InspectorHeapProfilerAgent.h"
#include "core/inspector/InspectorInputAgent.h"
#include "core/inspector/InspectorInspectorAgent.h"
@@ -67,7 +66,6 @@
#include "core/inspector/PageConsoleAgent.h"
#include "core/inspector/PageDebuggerAgent.h"
#include "core/inspector/PageRuntimeAgent.h"
-#include "core/page/ContextMenuProvider.h"
#include "core/page/Page.h"
#include "core/rendering/RenderLayer.h"
#include "platform/PlatformMouseEvent.h"
@@ -83,7 +81,6 @@ InspectorController::InspectorController(Page* page, InspectorClient* inspectorC
, m_resourceAgent(nullptr)
, m_layerTreeAgent(nullptr)
, m_animationAgent(nullptr)
- , m_inspectorFrontendClient(nullptr)
, m_inspectorClient(inspectorClient)
, m_agents(m_instrumentingAgents.get(), m_state.get())
, m_isUnderTest(false)
@@ -231,8 +228,6 @@ void InspectorController::willBeDestroyed()
m_inspectorClient = 0;
m_instrumentingAgents->reset();
m_agents.discardAgents();
- if (m_inspectorFrontendClient)
- m_inspectorFrontendClient->dispose();
}
void InspectorController::registerModuleAgent(PassOwnPtrWillBeRawPtr<InspectorAgent> agent)
@@ -240,19 +235,6 @@ void InspectorController::registerModuleAgent(PassOwnPtrWillBeRawPtr<InspectorAg
m_agents.append(agent);
}
-void InspectorController::setInspectorFrontendClient(InspectorFrontendClient* inspectorFrontendClient)
-{
- m_inspectorFrontendClient = inspectorFrontendClient;
-}
-
-void InspectorController::didClearDocumentOfWindowObject(LocalFrame* frame)
-{
- // If the page is supposed to serve as InspectorFrontend notify inspector frontend
- // client that it's cleared so that the client can expose inspector bindings.
- if (m_inspectorFrontendClient && frame == m_pageAgent->inspectedFrame())
- m_inspectorFrontendClient->windowObjectCleared();
-}
-
void InspectorController::connectFrontend(const String& hostId, InspectorFrontendChannel* frontendChannel)
{
ASSERT(frontendChannel);
@@ -364,19 +346,6 @@ void InspectorController::inspect(Node* node)
injectedScript.inspectNode(node);
}
-void InspectorController::setInjectedScriptForOrigin(const String& origin, const String& source)
-{
- if (InspectorInspectorAgent* inspectorAgent = m_instrumentingAgents->inspectorInspectorAgent())
- inspectorAgent->setInjectedScriptForOrigin(origin, source);
-}
-
-void InspectorController::showContextMenu(float x, float y, PassRefPtrWillBeRawPtr<ContextMenuProvider> menuProvider)
-{
- if (!m_inspectorClient)
- return;
- m_inspectorClient->showContextMenu(x, y, menuProvider);
-}
-
void InspectorController::dispatchMessageFromFrontend(const String& message)
{
if (m_inspectorBackendDispatcher)
« no previous file with comments | « Source/core/inspector/InspectorController.h ('k') | Source/core/inspector/InspectorFrontendClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698