Add use counters for missing arguments to window.{move,resize}{To,By}

Add use counters for missing arguments to window.{move,resize}{To,By}

In preparation of making the arguments non-optional, per spec, add counters
to determine how much impact this would have.

BUG=453421
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189559

[Jens Widell, 2015-02-05 10:01:21]

jl@opera.com changed reviewers:
+ mkwst@chromium.org, philipj@opera.com

[Jens Widell, 2015-02-05 10:01:21]

PTAL

mkwst@: sorry for making the very thing you disliked in the initial patch even
worse...

[Mike West, 2015-02-05 10:03:39]

LBTM. :(

But as long as it's temporary, LGTM.

[Jens Widell, 2015-02-05 10:06:14]

On 2015/02/05 10:03:39, Mike West wrote:
> LBTM. :(
> 
> But as long as it's temporary, LGTM.

I assume we'll either land https://codereview.chromium.org/886463010/ or (just)
drop the counters ASAP. But it'll be here for a while, I suppose.

Thanks for reviewing!

[philipj_slow, 2015-02-05 10:13:58]

https://codereview.chromium.org/900203002/diff/1/Source/core/frame/LocalDOMWi...
File Source/core/frame/LocalDOMWindow.cpp (right):

https://codereview.chromium.org/900203002/diff/1/Source/core/frame/LocalDOMWi...
Source/core/frame/LocalDOMWindow.cpp:1409: UseCounter::count(document(),
UseCounter::WindowMoveResizeMissingArguments);
It could well be that there's only a single 1-argument form of one of these
functions that is used. I would actually add 8 counters, 2 per method, to learn
as much as possible about the situation.

[Jens Widell, 2015-02-05 10:19:52]

https://codereview.chromium.org/900203002/diff/1/Source/core/frame/LocalDOMWi...
File Source/core/frame/LocalDOMWindow.cpp (right):

https://codereview.chromium.org/900203002/diff/1/Source/core/frame/LocalDOMWi...
Source/core/frame/LocalDOMWindow.cpp:1409: UseCounter::count(document(),
UseCounter::WindowMoveResizeMissingArguments);
On 2015/02/05 10:13:58, philipj_UTC7 wrote:
> It could well be that there's only a single 1-argument form of one of these
> functions that is used. I would actually add 8 counters, 2 per method, to
learn
> as much as possible about the situation.

I reasoned that the possible outcomes were to either change all four method the
same way, or not change any of them, and thus that only the one counter (or the
sum of your 8 counters) actually mattered. But I guess we could change only some
subset of the methods (change *By, but not *To, for instance.)

I don't think we should consider changing any of the methods to have one
required and one optional argument, so I don't see much value in separately
measuring zero and one argument calls.

[philipj_slow, 2015-02-05 12:12:25]

I don't know, *By(x) to only * horizontally could make some sense.

But I suppose there's little gain in changing the spec to some middle ground and
require all browsers to change instead of just some. LGTM like this.

[Jens Widell, 2015-02-05 12:49:01]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2015-02-05 12:49:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900203002/1

[commit-bot: I haz the power, 2015-02-05 15:12:22]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189559