Source/core/frame/RemoteDOMWindow.cpp - Issue 900203002: Add use counters for missing arguments to window.{move,resize}{To,By}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/RemoteDOMWindow.cpp

Issue 900203002: Add use counters for missing arguments to window.{move,resize}{To,By} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/RemoteDOMWindow.cpp

diff --git a/Source/core/frame/RemoteDOMWindow.cpp b/Source/core/frame/RemoteDOMWindow.cpp

index 93bcb89e7b83cf91c589e208bd1307aea482fff7..9512e2d189a1e625a883ad0db76910257ac6b883 100644

--- a/Source/core/frame/RemoteDOMWindow.cpp

+++ b/Source/core/frame/RemoteDOMWindow.cpp

@@ -301,7 +301,7 @@ void RemoteDOMWindow::scrollTo(const ScrollToOptions&) const

ASSERT_NOT_REACHED();

}

-void RemoteDOMWindow::moveBy(int x, int y) const

+void RemoteDOMWindow::moveBy(int x, int y, bool hasX, bool hasY) const

{

ASSERT_NOT_REACHED();

}

@@ -311,7 +311,7 @@ void RemoteDOMWindow::moveTo(int x, int y, bool hasX, bool hasY) const

ASSERT_NOT_REACHED();

}

-void RemoteDOMWindow::resizeBy(int x, int y) const

+void RemoteDOMWindow::resizeBy(int x, int y, bool hasX, bool hasY) const

{

ASSERT_NOT_REACHED();

}

« Source/core/frame/LocalDOMWindow.cpp ('K') | « Source/core/frame/RemoteDOMWindow.h ('k') | Source/core/frame/UseCounter.h » ('j') | no next file with comments »