Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Unified Diff: Source/core/frame/DOMWindow.h

Issue 900203002: Add use counters for missing arguments to window.{move,resize}{To,By} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/LocalDOMWindow.h » ('j') | Source/core/frame/LocalDOMWindow.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/DOMWindow.h
diff --git a/Source/core/frame/DOMWindow.h b/Source/core/frame/DOMWindow.h
index ed475d7d5985026387aeb059959e394e42dc2af5..6bd5a454db7df7c7f687866c535f390eb436641d 100644
--- a/Source/core/frame/DOMWindow.h
+++ b/Source/core/frame/DOMWindow.h
@@ -148,12 +148,16 @@ public:
virtual void scrollTo(const ScrollToOptions&) const = 0;
void scroll(double x, double y) const { scrollTo(x, y); }
void scroll(const ScrollToOptions& scrollToOptions) const { scrollTo(scrollToOptions); }
- virtual void moveBy(int x, int y) const = 0;
+ void moveBy() const { moveBy(0, 0, false, false); }
+ void moveBy(int x) const { moveBy(x, 0, true, false); }
+ virtual void moveBy(int x, int y, bool hasX = true, bool hasY = true) const = 0;
void moveTo() const { moveTo(0, 0, false, false); }
void moveTo(int x) const { moveTo(x, 0, true, false); }
virtual void moveTo(int x, int y, bool hasX = true, bool hasY = true) const = 0;
- virtual void resizeBy(int x, int y) const = 0;
+ void resizeBy() const { resizeBy(0, 0, false, false); }
+ void resizeBy(int x) const { resizeBy(x, 0, true, false); }
+ virtual void resizeBy(int x, int y, bool hasX = true, bool hasY = true) const = 0;
void resizeTo() const { resizeTo(0, 0, false, false); }
void resizeTo(int x) const { resizeTo(x, 0, true, false); }
virtual void resizeTo(int width, int height, bool hasWidth = true, bool hasHeight = true) const = 0;
« no previous file with comments | « no previous file | Source/core/frame/LocalDOMWindow.h » ('j') | Source/core/frame/LocalDOMWindow.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698