Add use counters for missing arguments to window.{move,resize}{To,By}

Source/core/frame/LocalDOMWindow.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 1385 matching lines @@
         if (std::isnan(scrollToOptions.top()))
             return;
         scaledY = scrollToOptions.top() * frame()->pageZoomFactor();
     }
 
     ScrollBehavior scrollBehavior = ScrollBehaviorAuto;
     ScrollableArea::scrollBehaviorFromString(scrollToOptions.behavior(), scrollBehavior);
     scrollViewportTo(frame(), DoublePoint(scaledX, scaledY), scrollBehavior);
 }
 
-void LocalDOMWindow::moveBy(int x, int y) const
+void LocalDOMWindow::moveBy(int x, int y, bool hasX, bool hasY) const
 {
+    if (!hasX || !hasY)
+        UseCounter::count(document(), UseCounter::WindowMoveResizeMissingArguments);

[philipj_slow, 2015/02/05 10:13:58]

It could well be that there's only a single 1-argument form of one of these
functions that is used. I would actually add 8 counters, 2 per method, to learn
as much as possible about the situation.

[Jens Widell, 2015/02/05 10:19:52]

I reasoned that the possible outcomes were to either change all four method the
same way, or not change any of them, and thus that only the one counter (or the
sum of your 8 counters) actually mattered. But I guess we could change only some
subset of the methods (change *By, but not *To, for instance.)

I don't think we should consider changing any of the methods to have one
required and one optional argument, so I don't see much value in separately
measuring zero and one argument calls.

+
     if (!frame() || !frame()->isMainFrame())
         return;
 
     FrameHost* host = frame()->host();
     if (!host)
         return;
 
     IntRect windowRect = host->chrome().windowRect();
     windowRect.move(x, y);
     // Security check (the spec talks about UniversalBrowserWrite to disable this check...)
     host->chrome().setWindowRect(adjustWindowRect(*frame(), windowRect));
 }
 
 void LocalDOMWindow::moveTo(int x, int y, bool hasX, bool hasY) const
 {
+    if (!hasX || !hasY)
+        UseCounter::count(document(), UseCounter::WindowMoveResizeMissingArguments);
+
     if (!frame() || !frame()->isMainFrame())
         return;
 
     FrameHost* host = frame()->host();
     if (!host)
         return;
 
     IntRect windowRect = host->chrome().windowRect();
     windowRect.setLocation(IntPoint(hasX ? x : windowRect.x(), hasY ? y : windowRect.y()));
     // Security check (the spec talks about UniversalBrowserWrite to disable this check...)
     host->chrome().setWindowRect(adjustWindowRect(*frame(), windowRect));
 }
 
-void LocalDOMWindow::resizeBy(int x, int y) const
+void LocalDOMWindow::resizeBy(int x, int y, bool hasX, bool hasY) const
 {
+    if (!hasX || !hasY)
+        UseCounter::count(document(), UseCounter::WindowMoveResizeMissingArguments);
+
     if (!frame() || !frame()->isMainFrame())
         return;
 
     FrameHost* host = frame()->host();
     if (!host)
         return;
 
     IntRect fr = host->chrome().windowRect();
     IntSize dest = fr.size() + IntSize(x, y);
     IntRect update(fr.location(), dest);
     host->chrome().setWindowRect(adjustWindowRect(*frame(), update));
 }
 
 void LocalDOMWindow::resizeTo(int width, int height, bool hasWidth, bool hasHeight) const
 {
+    if (!hasWidth || !hasHeight)
+        UseCounter::count(document(), UseCounter::WindowMoveResizeMissingArguments);
+
     if (!frame() || !frame()->isMainFrame())
         return;
 
     FrameHost* host = frame()->host();
     if (!host)
         return;
 
     IntRect fr = host->chrome().windowRect();
     IntSize dest = IntSize(hasWidth ? width : fr.width(), hasHeight ? height : fr.height());
     IntRect update(fr.location(), dest);
@@ skipping 372 matching lines @@
     return m_frameObserver->frame();
 }
 
 v8::Handle<v8::Object> LocalDOMWindow::wrap(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     ASSERT_NOT_REACHED(); // LocalDOMWindow has [Custom=ToV8].
     return v8::Handle<v8::Object>();
 }
 
 } // namespace blink