Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 899033002: Revert of Combine PDF plugin into the Chromium binary. (Closed)

Created:
5 years, 10 months ago by kelvinp
Modified:
5 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5), jam
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Combine PDF plugin into the Chromium binary. (patchset #17 id:380001 of https://codereview.chromium.org/799643004/) Reason for revert: Compile step failed on Official Chrome See http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/55563/steps/compile/logs/stdio ninja: error: 'libpdf.so', needed by 'google-chrome-stable-42.0.2296.0-1.x86_64.rpm', missing and no known rule to make it Original issue's description: > Combine PDF plugin into the Chromium binary. > > On Windows, this moves it to chrome_child.dll. Overall binary sizes is 4.5 MB smaller (chrome_child.dll gets 3.6 MB larger while we drop the 8.1 MB pdf.dll). On Mac, the binary is 6.6 MB smaller. On Linux, it's 7MB smaller. This is from official release builds, after stripping on Linux. > > The size savings are because we don't ship duplicate versions of V8, and also the PDF plugin uses some of base and net. > > This depends on OOP PDF, since otherwise the V8 isolates for the plugin and Blink interact badly. That got turned on a few weeks ago. > > BUG=453844 > > Committed: https://crrev.com/dc0e4390c0364515fa360c5292a4389784580a48 > Cr-Commit-Position: refs/heads/master@{#314575} BUG=453844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+821 lines, -265 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/BUILD.gn View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/chrome_main_delegate.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/file_manager/open_with_browser.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_preview_pdf_generated_browsertest.cc View 8 chunks +83 lines, -20 lines 0 comments Download
M chrome/browser/resources/pdf/pdf_extension_test.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/child/pdf_child_init.cc View 1 chunk +9 lines, -14 lines 0 comments Download
M chrome/chrome.isolate View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 3 chunks +3 lines, -10 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 2 chunks +14 lines, -5 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_content_client.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 4 chunks +39 lines, -33 lines 0 comments Download
M chrome/common/chrome_content_client_constants.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/chrome_paths.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_paths.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/utility/printing_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/utility/printing_handler.cc View 8 chunks +188 lines, -13 lines 0 comments Download
M pdf/BUILD.gn View 4 chunks +26 lines, -4 lines 0 comments Download
A pdf/Info.plist View 1 chunk +44 lines, -0 lines 0 comments Download
M pdf/pdf.h View 2 chunks +0 lines, -89 lines 0 comments Download
M pdf/pdf.cc View 7 chunks +130 lines, -31 lines 0 comments Download
A pdf/pdf.def View 1 chunk +7 lines, -0 lines 0 comments Download
M pdf/pdf.gyp View 4 chunks +123 lines, -4 lines 0 comments Download
A pdf/pdf.rc View 1 chunk +104 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
kelvinp
Created Revert of Combine PDF plugin into the Chromium binary.
5 years, 10 months ago (2015-02-04 17:53:32 UTC) #1
bshe
5 years, 10 months ago (2015-02-09 14:27:51 UTC) #3
Message was sent while issue was closed.
On 2015/02/04 17:53:32, kelvinp wrote:
> Created Revert of Combine PDF plugin into the Chromium binary.

It looks like this is not submitted. No revision number is found and TOT doesn't
include the revert. Is this intentional? Some of the PDF related tests failed
possibly related to the original CL.

Powered by Google App Engine
This is Rietveld 408576698