Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8030)

Unified Diff: chrome/chrome_exe.gypi

Issue 899033002: Revert of Combine PDF plugin into the Chromium binary. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_dll_bundle.gypi ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_exe.gypi
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi
index 12d15286cd6dfb8fa20c5239de2d2c31818f9c87..e27baa88c17857c34c158903d64a9cd9de7a7158 100644
--- a/chrome/chrome_exe.gypi
+++ b/chrome/chrome_exe.gypi
@@ -188,11 +188,6 @@
'../build/linux/system.gyp:xext',
],
}],
- ['enable_plugins==1', {
- 'dependencies': [
- '../pdf/pdf.gyp:pdf',
- ],
- }],
],
'sources': [
'app/chrome_dll_resource.h',
@@ -431,6 +426,20 @@
# NOTE: chrome/app/theme/chromium/BRANDING and
# chrome/app/theme/google_chrome/BRANDING have the short name
# "chrome" etc.; should we try to extract from there instead?
+
+ # CrOS does this in a separate build step.
+ ['OS=="linux" and chromeos==0 and linux_dump_symbols==1', {
+ 'dependencies': [
+ '../pdf/pdf.gyp:pdf_linux_symbols',
+ ],
+ }], # OS=="linux" and chromeos==0 and linux_dump_symbols==1
+ # Android doesn't use pdfium.
+ ['OS!="android"', {
+ 'dependencies': [
+ # On Mac, this is done in chrome_dll.gypi.
+ '../pdf/pdf.gyp:pdf',
+ ],
+ }], # OS=="android"
],
'dependencies': [
'../components/components.gyp:startup_metric_utils',
« no previous file with comments | « chrome/chrome_dll_bundle.gypi ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698