Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: chrome/BUILD.gn

Issue 899033002: Revert of Combine PDF plugin into the Chromium binary. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/all.gyp ('k') | chrome/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index ca8267cc296066dbaf12a9c56d1c72b2b70d935c..b323084135768a3d6320fb82aff91963cfd2a94f 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -150,8 +150,10 @@
# TODO(GYP) some stuff from GYP including chrome_multiple_dll.
}
- if (enable_plugins) {
- deps += [ "//pdf" ]
+ if (!is_mac) {
+ # On Mac this is done in chrome_dll.gypi.
+ datadeps += [ "//pdf" ]
+ # TODO(GYP) pdf linux symbols
}
}
} # !is_android
@@ -234,10 +236,6 @@
# 'includes': [ 'chrome_dll_bundle.gypi' ],
#}],
# TODO(GYP) Lots of other stuff in the OS=="mac" block.
- }
-
- if (enable_plugins) {
- deps += [ "//pdf" ]
}
}
}
« no previous file with comments | « build/all.gyp ('k') | chrome/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698