Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 896643003: Class methods should be non enumerable (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Class methods should be non enumerable Class methods and accessors (both prototype and static) should be non enumerable. BUG=v8:3330 LOG=Y R=dslomov@chromium.org Committed: https://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54 Cr-Commit-Position: refs/heads/master@{#26437}

Patch Set 1 #

Patch Set 2 : formatting #

Total comments: 1

Patch Set 3 : Use LanguageMode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -61 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 2 chunks +12 lines, -4 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 2 chunks +12 lines, -4 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 2 chunks +12 lines, -8 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 2 chunks +12 lines, -4 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 2 2 chunks +12 lines, -4 lines 0 comments Download
M src/objects.h View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 1 chunk +10 lines, -4 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/classes.js View 4 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/computed-property-names-classes.js View 9 chunks +32 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
arv (Not doing code reviews)
formatting
5 years, 10 months ago (2015-02-03 17:36:59 UTC) #1
arv (Not doing code reviews)
PTAL
5 years, 10 months ago (2015-02-03 17:37:34 UTC) #2
arv (Not doing code reviews)
https://codereview.chromium.org/896643003/diff/20001/src/runtime/runtime-object.cc File src/runtime/runtime-object.cc (right): https://codereview.chromium.org/896643003/diff/20001/src/runtime/runtime-object.cc#newcode1596 src/runtime/runtime-object.cc:1596: CONVERT_SMI_ARG_CHECKED(unchecked, 3); I'm going to do a followup CL ...
5 years, 10 months ago (2015-02-03 17:38:36 UTC) #3
arv (Not doing code reviews)
Adding Adam
5 years, 10 months ago (2015-02-03 18:59:10 UTC) #5
adamk
lgtm
5 years, 10 months ago (2015-02-03 19:07:04 UTC) #6
Dmitry Lomov (no reviews)
lgtm (I presume we have tests that check that object literal concise methods are still ...
5 years, 10 months ago (2015-02-04 10:36:09 UTC) #7
arv (Not doing code reviews)
On 2015/02/04 10:36:09, Dmitry Lomov (chromium) wrote: > lgtm (I presume we have tests that ...
5 years, 10 months ago (2015-02-04 16:01:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896643003/20001
5 years, 10 months ago (2015-02-04 16:02:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/1124)
5 years, 10 months ago (2015-02-04 16:21:18 UTC) #12
arv (Not doing code reviews)
Use LanguageMode
5 years, 10 months ago (2015-02-04 16:33:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896643003/40001
5 years, 10 months ago (2015-02-04 16:34:02 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-04 17:23:16 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 17:23:23 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/176b68d11a2b485d9568d2e7fd03e6ed7b67dd54
Cr-Commit-Position: refs/heads/master@{#26437}

Powered by Google App Engine
This is Rietveld 408576698