Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 896643003: Class methods should be non enumerable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Use LanguageMode Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1813 matching lines...) Expand 10 before | Expand all | Expand 10 after
1824 } else { 1824 } else {
1825 __ Drop(3); 1825 __ Drop(3);
1826 } 1826 }
1827 break; 1827 break;
1828 1828
1829 case ObjectLiteral::Property::PROTOTYPE: 1829 case ObjectLiteral::Property::PROTOTYPE:
1830 UNREACHABLE(); 1830 UNREACHABLE();
1831 break; 1831 break;
1832 1832
1833 case ObjectLiteral::Property::GETTER: 1833 case ObjectLiteral::Property::GETTER:
1834 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3); 1834 __ mov(r0, Operand(Smi::FromInt(NONE)));
1835 __ push(r0);
1836 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 4);
1835 break; 1837 break;
1836 1838
1837 case ObjectLiteral::Property::SETTER: 1839 case ObjectLiteral::Property::SETTER:
1838 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3); 1840 __ mov(r0, Operand(Smi::FromInt(NONE)));
1841 __ push(r0);
1842 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 4);
1839 break; 1843 break;
1840 } 1844 }
1841 } 1845 }
1842 } 1846 }
1843 1847
1844 if (expr->has_function()) { 1848 if (expr->has_function()) {
1845 DCHECK(result_saved); 1849 DCHECK(result_saved);
1846 __ ldr(r0, MemOperand(sp)); 1850 __ ldr(r0, MemOperand(sp));
1847 __ push(r0); 1851 __ push(r0);
1848 __ CallRuntime(Runtime::kToFastProperties, 1); 1852 __ CallRuntime(Runtime::kToFastProperties, 1);
(...skipping 708 matching lines...) Expand 10 before | Expand all | Expand 10 after
2557 switch (property->kind()) { 2561 switch (property->kind()) {
2558 case ObjectLiteral::Property::CONSTANT: 2562 case ObjectLiteral::Property::CONSTANT:
2559 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 2563 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
2560 case ObjectLiteral::Property::PROTOTYPE: 2564 case ObjectLiteral::Property::PROTOTYPE:
2561 UNREACHABLE(); 2565 UNREACHABLE();
2562 case ObjectLiteral::Property::COMPUTED: 2566 case ObjectLiteral::Property::COMPUTED:
2563 __ CallRuntime(Runtime::kDefineClassMethod, 3); 2567 __ CallRuntime(Runtime::kDefineClassMethod, 3);
2564 break; 2568 break;
2565 2569
2566 case ObjectLiteral::Property::GETTER: 2570 case ObjectLiteral::Property::GETTER:
2567 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3); 2571 __ mov(r0, Operand(Smi::FromInt(DONT_ENUM)));
2572 __ push(r0);
2573 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 4);
2568 break; 2574 break;
2569 2575
2570 case ObjectLiteral::Property::SETTER: 2576 case ObjectLiteral::Property::SETTER:
2571 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3); 2577 __ mov(r0, Operand(Smi::FromInt(DONT_ENUM)));
2578 __ push(r0);
2579 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 4);
2572 break; 2580 break;
2573 2581
2574 default: 2582 default:
2575 UNREACHABLE(); 2583 UNREACHABLE();
2576 } 2584 }
2577 } 2585 }
2578 2586
2579 // prototype 2587 // prototype
2580 __ CallRuntime(Runtime::kToFastProperties, 1); 2588 __ CallRuntime(Runtime::kToFastProperties, 1);
2581 2589
(...skipping 2840 matching lines...) Expand 10 before | Expand all | Expand 10 after
5422 5430
5423 DCHECK(interrupt_address == 5431 DCHECK(interrupt_address ==
5424 isolate->builtins()->OsrAfterStackCheck()->entry()); 5432 isolate->builtins()->OsrAfterStackCheck()->entry());
5425 return OSR_AFTER_STACK_CHECK; 5433 return OSR_AFTER_STACK_CHECK;
5426 } 5434 }
5427 5435
5428 5436
5429 } } // namespace v8::internal 5437 } } // namespace v8::internal
5430 5438
5431 #endif // V8_TARGET_ARCH_ARM 5439 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698