Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 896643003: Class methods should be non enumerable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Use LanguageMode Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime-object.cc ('k') | src/x87/full-codegen-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1768 matching lines...) Expand 10 before | Expand all | Expand 10 after
1779 } else { 1779 } else {
1780 __ Drop(3); 1780 __ Drop(3);
1781 } 1781 }
1782 break; 1782 break;
1783 1783
1784 case ObjectLiteral::Property::PROTOTYPE: 1784 case ObjectLiteral::Property::PROTOTYPE:
1785 UNREACHABLE(); 1785 UNREACHABLE();
1786 break; 1786 break;
1787 1787
1788 case ObjectLiteral::Property::GETTER: 1788 case ObjectLiteral::Property::GETTER:
1789 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3); 1789 __ Push(Smi::FromInt(NONE));
1790 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 4);
1790 break; 1791 break;
1791 1792
1792 case ObjectLiteral::Property::SETTER: 1793 case ObjectLiteral::Property::SETTER:
1793 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3); 1794 __ Push(Smi::FromInt(NONE));
1795 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 4);
1794 break; 1796 break;
1795 } 1797 }
1796 } 1798 }
1797 } 1799 }
1798 1800
1799 if (expr->has_function()) { 1801 if (expr->has_function()) {
1800 DCHECK(result_saved); 1802 DCHECK(result_saved);
1801 __ Push(Operand(rsp, 0)); 1803 __ Push(Operand(rsp, 0));
1802 __ CallRuntime(Runtime::kToFastProperties, 1); 1804 __ CallRuntime(Runtime::kToFastProperties, 1);
1803 } 1805 }
(...skipping 665 matching lines...) Expand 10 before | Expand all | Expand 10 after
2469 switch (property->kind()) { 2471 switch (property->kind()) {
2470 case ObjectLiteral::Property::CONSTANT: 2472 case ObjectLiteral::Property::CONSTANT:
2471 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 2473 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
2472 case ObjectLiteral::Property::PROTOTYPE: 2474 case ObjectLiteral::Property::PROTOTYPE:
2473 UNREACHABLE(); 2475 UNREACHABLE();
2474 case ObjectLiteral::Property::COMPUTED: 2476 case ObjectLiteral::Property::COMPUTED:
2475 __ CallRuntime(Runtime::kDefineClassMethod, 3); 2477 __ CallRuntime(Runtime::kDefineClassMethod, 3);
2476 break; 2478 break;
2477 2479
2478 case ObjectLiteral::Property::GETTER: 2480 case ObjectLiteral::Property::GETTER:
2479 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3); 2481 __ Push(Smi::FromInt(DONT_ENUM));
2482 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 4);
2480 break; 2483 break;
2481 2484
2482 case ObjectLiteral::Property::SETTER: 2485 case ObjectLiteral::Property::SETTER:
2483 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3); 2486 __ Push(Smi::FromInt(DONT_ENUM));
2487 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 4);
2484 break; 2488 break;
2485 2489
2486 default: 2490 default:
2487 UNREACHABLE(); 2491 UNREACHABLE();
2488 } 2492 }
2489 } 2493 }
2490 2494
2491 // prototype 2495 // prototype
2492 __ CallRuntime(Runtime::kToFastProperties, 1); 2496 __ CallRuntime(Runtime::kToFastProperties, 1);
2493 2497
(...skipping 2820 matching lines...) Expand 10 before | Expand all | Expand 10 after
5314 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5318 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5315 Assembler::target_address_at(call_target_address, 5319 Assembler::target_address_at(call_target_address,
5316 unoptimized_code)); 5320 unoptimized_code));
5317 return OSR_AFTER_STACK_CHECK; 5321 return OSR_AFTER_STACK_CHECK;
5318 } 5322 }
5319 5323
5320 5324
5321 } } // namespace v8::internal 5325 } } // namespace v8::internal
5322 5326
5323 #endif // V8_TARGET_ARCH_X64 5327 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/runtime/runtime-object.cc ('k') | src/x87/full-codegen-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698