Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 896643003: Class methods should be non enumerable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Use LanguageMode Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1734 matching lines...) Expand 10 before | Expand all | Expand 10 after
1745 } else { 1745 } else {
1746 __ Drop(3); 1746 __ Drop(3);
1747 } 1747 }
1748 break; 1748 break;
1749 1749
1750 case ObjectLiteral::Property::PROTOTYPE: 1750 case ObjectLiteral::Property::PROTOTYPE:
1751 UNREACHABLE(); 1751 UNREACHABLE();
1752 break; 1752 break;
1753 1753
1754 case ObjectLiteral::Property::GETTER: 1754 case ObjectLiteral::Property::GETTER:
1755 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3); 1755 __ push(Immediate(Smi::FromInt(NONE)));
1756 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 4);
1756 break; 1757 break;
1757 1758
1758 case ObjectLiteral::Property::SETTER: 1759 case ObjectLiteral::Property::SETTER:
1759 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3); 1760 __ push(Immediate(Smi::FromInt(NONE)));
1761 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 4);
1760 break; 1762 break;
1761 } 1763 }
1762 } 1764 }
1763 } 1765 }
1764 1766
1765 if (expr->has_function()) { 1767 if (expr->has_function()) {
1766 DCHECK(result_saved); 1768 DCHECK(result_saved);
1767 __ push(Operand(esp, 0)); 1769 __ push(Operand(esp, 0));
1768 __ CallRuntime(Runtime::kToFastProperties, 1); 1770 __ CallRuntime(Runtime::kToFastProperties, 1);
1769 } 1771 }
(...skipping 700 matching lines...) Expand 10 before | Expand all | Expand 10 after
2470 switch (property->kind()) { 2472 switch (property->kind()) {
2471 case ObjectLiteral::Property::CONSTANT: 2473 case ObjectLiteral::Property::CONSTANT:
2472 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 2474 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
2473 case ObjectLiteral::Property::PROTOTYPE: 2475 case ObjectLiteral::Property::PROTOTYPE:
2474 UNREACHABLE(); 2476 UNREACHABLE();
2475 case ObjectLiteral::Property::COMPUTED: 2477 case ObjectLiteral::Property::COMPUTED:
2476 __ CallRuntime(Runtime::kDefineClassMethod, 3); 2478 __ CallRuntime(Runtime::kDefineClassMethod, 3);
2477 break; 2479 break;
2478 2480
2479 case ObjectLiteral::Property::GETTER: 2481 case ObjectLiteral::Property::GETTER:
2480 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3); 2482 __ push(Immediate(Smi::FromInt(DONT_ENUM)));
2483 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 4);
2481 break; 2484 break;
2482 2485
2483 case ObjectLiteral::Property::SETTER: 2486 case ObjectLiteral::Property::SETTER:
2484 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3); 2487 __ push(Immediate(Smi::FromInt(DONT_ENUM)));
2488 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 4);
2485 break; 2489 break;
2486 } 2490 }
2487 } 2491 }
2488 2492
2489 // prototype 2493 // prototype
2490 __ CallRuntime(Runtime::kToFastProperties, 1); 2494 __ CallRuntime(Runtime::kToFastProperties, 1);
2491 2495
2492 // constructor 2496 // constructor
2493 __ CallRuntime(Runtime::kToFastProperties, 1); 2497 __ CallRuntime(Runtime::kToFastProperties, 1);
2494 } 2498 }
(...skipping 2796 matching lines...) Expand 10 before | Expand all | Expand 10 after
5291 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5295 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5292 Assembler::target_address_at(call_target_address, 5296 Assembler::target_address_at(call_target_address,
5293 unoptimized_code)); 5297 unoptimized_code));
5294 return OSR_AFTER_STACK_CHECK; 5298 return OSR_AFTER_STACK_CHECK;
5295 } 5299 }
5296 5300
5297 5301
5298 } } // namespace v8::internal 5302 } } // namespace v8::internal
5299 5303
5300 #endif // V8_TARGET_ARCH_IA32 5304 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698