Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 894373004: Add glGetActiveUniformBlockiv to GPU command buffer. (Closed)

Created:
5 years, 10 months ago by Zhenyao Mo
Modified:
5 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews, Ken Russell (switch to Gerrit), no sievers, bajones, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add glGetActiveUniformBlockiv to GPU command buffer. BUG=429053 TEST=gpu_unittests R=piman@chromium.org NOTRY=True Committed: https://crrev.com/a2b555dcfa8774310f227594e93ffab6631720ee Cr-Commit-Position: refs/heads/master@{#315135}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : Fix win bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+792 lines, -282 lines) Patch
M gpu/GLES2/gl2chromium_autogen.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 2 chunks +21 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 chunk +12 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 2 chunks +47 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/program_info_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download
M gpu/command_buffer/client/program_info_manager_unittest.cc View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 chunk +62 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 chunk +18 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +193 lines, -192 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 1 chunk +17 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 1 chunk +57 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 2 chunks +2 lines, -74 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 2 chunks +73 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +12 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc View 1 1 chunk +169 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Zhenyao Mo
piman: please review. Others: FYI (feel free to review)
5 years, 10 months ago (2015-02-06 21:42:30 UTC) #4
piman
lgtm
5 years, 10 months ago (2015-02-06 21:56:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894373004/80001
5 years, 10 months ago (2015-02-06 22:15:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/23970)
5 years, 10 months ago (2015-02-06 23:39:16 UTC) #10
Zhenyao Mo
On 2015/02/06 23:39:16, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-02-06 23:47:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894373004/80001
5 years, 10 months ago (2015-02-06 23:48:41 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 10 months ago (2015-02-06 23:50:47 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 23:51:41 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a2b555dcfa8774310f227594e93ffab6631720ee
Cr-Commit-Position: refs/heads/master@{#315135}

Powered by Google App Engine
This is Rietveld 408576698