gpu/command_buffer/client/program_info_manager.cc - Issue 894373004: Add glGetActiveUniformBlockiv to GPU command buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/client/program_info_manager.cc

Issue 894373004: Add glGetActiveUniformBlockiv to GPU command buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix win bots Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h ('k') | gpu/command_buffer/client/program_info_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/client/program_info_manager.cc

diff --git a/gpu/command_buffer/client/program_info_manager.cc b/gpu/command_buffer/client/program_info_manager.cc

index 04121aa7346ba275391dc30102909c31d47cf304..b13f7c979b60227e97d71933ece5ff2cc4d36e2c 100644

--- a/gpu/command_buffer/client/program_info_manager.cc

+++ b/gpu/command_buffer/client/program_info_manager.cc

@@ -635,9 +635,7 @@ bool ProgramInfoManager::GetActiveUniformBlockiv(

}

- return false;

- // TODO(zmo): return gl->GetActiveUniformBlockivHelper(

- // program, index, pname, params);

+ return gl->GetActiveUniformBlockivHelper(program, index, pname, params);

}

} // namespace gles2