Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 893343002: Update {virtual,override,final} to follow C++11 style. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
michaelbai
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=michaelbai@chromium.org Committed: https://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0 Cr-Commit-Position: refs/heads/master@{#314487}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -222 lines) Patch
M android_webview/native/android_protocol_handler.cc View 3 chunks +19 lines, -23 lines 0 comments Download
M android_webview/native/aw_autofill_client.h View 1 chunk +23 lines, -28 lines 0 comments Download
M android_webview/native/aw_contents.h View 4 chunks +29 lines, -35 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge.h View 1 chunk +10 lines, -10 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.h View 1 chunk +16 lines, -16 lines 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/native/aw_dev_tools_server.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/native/aw_http_auth_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/native/aw_media_url_interceptor.h View 1 chunk +4 lines, -4 lines 0 comments Download
M android_webview/native/aw_message_port_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_pdf_exporter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M android_webview/native/aw_quota_manager_bridge_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_settings.h View 2 chunks +3 lines, -4 lines 0 comments Download
M android_webview/native/aw_web_contents_delegate.h View 1 1 chunk +32 lines, -34 lines 0 comments Download
M android_webview/native/aw_web_contents_view_delegate.h View 1 chunk +4 lines, -5 lines 0 comments Download
M android_webview/native/aw_web_preferences_populater_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/native/aw_web_resource_response_impl.h View 1 chunk +10 lines, -11 lines 0 comments Download
M android_webview/native/external_video_surface_container_impl.h View 2 chunks +7 lines, -7 lines 0 comments Download
M android_webview/native/input_stream_impl.h View 1 chunk +5 lines, -4 lines 0 comments Download
M android_webview/native/input_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/permission/media_access_permission_request.h View 1 chunk +4 lines, -4 lines 0 comments Download
M android_webview/native/permission/media_access_permission_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/permission/permission_request_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/native/permission/permission_request_handler_unittest.cc View 3 chunks +6 lines, -13 lines 0 comments Download
M android_webview/native/permission/simple_permission_request.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
5 years, 10 months ago (2015-02-04 00:47:34 UTC) #1
michaelbai
lgtm
5 years, 10 months ago (2015-02-04 01:22:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893343002/1
5 years, 10 months ago (2015-02-04 01:48:47 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/55118) ios_rel_device_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/7059) ios_rel_device_ninja_ng ...
5 years, 10 months ago (2015-02-04 01:52:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893343002/20001
5 years, 10 months ago (2015-02-04 02:20:38 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 02:57:26 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 02:58:46 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9b4dd1aa9e96c92ec4503eefea2c9770001f95f0
Cr-Commit-Position: refs/heads/master@{#314487}

Powered by Google App Engine
This is Rietveld 408576698