android_webview/native/aw_pdf_exporter.h - Issue 893343002: Update {virtual,override,final} to follow C++11 style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_pdf_exporter.h

Issue 893343002: Update {virtual,override,final} to follow C++11 style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/native/aw_message_port_service_impl.h ('k') | android_webview/native/aw_quota_manager_bridge_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_pdf_exporter.h

diff --git a/android_webview/native/aw_pdf_exporter.h b/android_webview/native/aw_pdf_exporter.h

index 9ead85e9428c6b2166dd9698d0e4f38a3961a961..132135456ad66711800ab1a03558944de6595844 100644

--- a/android_webview/native/aw_pdf_exporter.h

+++ b/android_webview/native/aw_pdf_exporter.h

@@ -30,7 +30,7 @@ class AwPdfExporter : public PrintManagerDelegate {

jobject obj,

content::WebContents* web_contents);

- virtual ~AwPdfExporter();

+ ~AwPdfExporter() override;

void ExportToPdf(JNIEnv* env,

jobject obj,

@@ -38,8 +38,8 @@ class AwPdfExporter : public PrintManagerDelegate {

jobject cancel_signal);

// Implement PrintManagerDelegate methods

- virtual void DidExportPdf(bool success) override;

- virtual bool IsCancelled() override;

+ void DidExportPdf(bool success) override;

+ bool IsCancelled() override;

private:

void CreatePdfSettings(JNIEnv* env, jobject obj);

« no previous file with comments | « android_webview/native/aw_message_port_service_impl.h ('k') | android_webview/native/aw_quota_manager_bridge_impl.h » ('j') | no next file with comments »