android_webview/native/permission/permission_request_handler.h - Issue 893343002: Update {virtual,override,final} to follow C++11 style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/permission/permission_request_handler.h

Issue 893343002: Update {virtual,override,final} to follow C++11 style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/native/permission/media_access_permission_request_unittest.cc ('k') | android_webview/native/permission/permission_request_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/permission/permission_request_handler.h

diff --git a/android_webview/native/permission/permission_request_handler.h b/android_webview/native/permission/permission_request_handler.h

index 2318b5712396f704e4e6e8e06f783088b9d41530..7b264f75c39ab25e426c0cd3a95991f7a582eaf1 100644

--- a/android_webview/native/permission/permission_request_handler.h

+++ b/android_webview/native/permission/permission_request_handler.h

@@ -27,7 +27,7 @@ class PermissionRequestHandler : public content::WebContentsObserver {

public:

PermissionRequestHandler(PermissionRequestHandlerClient* client,

content::WebContents* aw_contents);

- virtual ~PermissionRequestHandler();

+ ~PermissionRequestHandler() override;

// Send the given |request| to PermissionRequestHandlerClient.

void SendRequest(scoped_ptr<AwPermissionRequestDelegate> request);

@@ -39,7 +39,7 @@ class PermissionRequestHandler : public content::WebContentsObserver {

void PreauthorizePermission(const GURL& origin, int64 resources);

// WebContentsObserver

- virtual void NavigationEntryCommitted(

+ void NavigationEntryCommitted(

const content::LoadCommittedDetails& load_details) override;

private: