Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: android_webview/native/permission/permission_request_handler_unittest.cc

Issue 893343002: Update {virtual,override,final} to follow C++11 style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/permission/aw_permission_request.h" 5 #include "android_webview/native/permission/aw_permission_request.h"
6 #include "android_webview/native/permission/aw_permission_request_delegate.h" 6 #include "android_webview/native/permission/aw_permission_request_delegate.h"
7 #include "android_webview/native/permission/permission_request_handler.h" 7 #include "android_webview/native/permission/permission_request_handler.h"
8 #include "android_webview/native/permission/permission_request_handler_client.h" 8 #include "android_webview/native/permission/permission_request_handler_client.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 12
13 namespace android_webview { 13 namespace android_webview {
14 14
15 class TestAwPermissionRequestDelegate : public AwPermissionRequestDelegate { 15 class TestAwPermissionRequestDelegate : public AwPermissionRequestDelegate {
16 public: 16 public:
17 TestAwPermissionRequestDelegate( 17 TestAwPermissionRequestDelegate(
18 const GURL& origin, int64 resources, base::Callback<void(bool)> callback) 18 const GURL& origin, int64 resources, base::Callback<void(bool)> callback)
19 : origin_(origin), 19 : origin_(origin),
20 resources_(resources), 20 resources_(resources),
21 callback_(callback) {} 21 callback_(callback) {}
22 22
23 // Get the origin which initiated the permission request. 23 // Get the origin which initiated the permission request.
24 virtual const GURL& GetOrigin() override { 24 const GURL& GetOrigin() override { return origin_; }
25 return origin_;
26 }
27 25
28 // Get the resources the origin wanted to access. 26 // Get the resources the origin wanted to access.
29 virtual int64 GetResources() override { 27 int64 GetResources() override { return resources_; }
30 return resources_;
31 }
32 28
33 // Notify the permission request is allowed or not. 29 // Notify the permission request is allowed or not.
34 virtual void NotifyRequestResult(bool allowed) override { 30 void NotifyRequestResult(bool allowed) override { callback_.Run(allowed); }
35 callback_.Run(allowed);
36 }
37 31
38 private: 32 private:
39 GURL origin_; 33 GURL origin_;
40 int64 resources_; 34 int64 resources_;
41 base::Callback<void(bool)> callback_; 35 base::Callback<void(bool)> callback_;
42 }; 36 };
43 37
44 class TestPermissionRequestHandlerClient : 38 class TestPermissionRequestHandlerClient :
45 public PermissionRequestHandlerClient { 39 public PermissionRequestHandlerClient {
46 public: 40 public:
47 struct Permission { 41 struct Permission {
48 Permission() 42 Permission()
49 :resources(0) {} 43 :resources(0) {}
50 Permission(const GURL& origin, int64 resources) 44 Permission(const GURL& origin, int64 resources)
51 : origin(origin), 45 : origin(origin),
52 resources(resources) {} 46 resources(resources) {}
53 GURL origin; 47 GURL origin;
54 int64 resources; 48 int64 resources;
55 }; 49 };
56 50
57 TestPermissionRequestHandlerClient() 51 TestPermissionRequestHandlerClient()
58 : request_(NULL) {} 52 : request_(NULL) {}
59 53
60 virtual void OnPermissionRequest(AwPermissionRequest* request) override { 54 void OnPermissionRequest(AwPermissionRequest* request) override {
61 request_ = request; 55 request_ = request;
62 requested_permission_ = 56 requested_permission_ =
63 Permission(request->GetOrigin(), request->GetResources()); 57 Permission(request->GetOrigin(), request->GetResources());
64 } 58 }
65 59
66 virtual void OnPermissionRequestCanceled( 60 void OnPermissionRequestCanceled(AwPermissionRequest* request) override {
67 AwPermissionRequest* request) override{
68 canceled_permission_ = 61 canceled_permission_ =
69 Permission(request->GetOrigin(), request->GetResources()); 62 Permission(request->GetOrigin(), request->GetResources());
70 } 63 }
71 64
72 AwPermissionRequest* request() { 65 AwPermissionRequest* request() {
73 return request_; 66 return request_;
74 } 67 }
75 68
76 const Permission& requested_permission() { 69 const Permission& requested_permission() {
77 return requested_permission_; 70 return requested_permission_;
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 public: 115 public:
123 PermissionRequestHandlerTest() 116 PermissionRequestHandlerTest()
124 : handler_(&client_), 117 : handler_(&client_),
125 allowed_(false) {} 118 allowed_(false) {}
126 119
127 void NotifyRequestResult(bool allowed) { 120 void NotifyRequestResult(bool allowed) {
128 allowed_ = allowed; 121 allowed_ = allowed;
129 } 122 }
130 123
131 protected: 124 protected:
132 virtual void SetUp() override { 125 void SetUp() override {
133 testing::Test::SetUp(); 126 testing::Test::SetUp();
134 origin_ = GURL("http://www.google.com"); 127 origin_ = GURL("http://www.google.com");
135 resources_ = 128 resources_ =
136 AwPermissionRequest::VideoCapture | AwPermissionRequest::AudioCapture; 129 AwPermissionRequest::VideoCapture | AwPermissionRequest::AudioCapture;
137 delegate_.reset( 130 delegate_.reset(
138 new TestAwPermissionRequestDelegate( 131 new TestAwPermissionRequestDelegate(
139 origin_, resources_, base::Bind( 132 origin_, resources_, base::Bind(
140 &PermissionRequestHandlerTest::NotifyRequestResult, 133 &PermissionRequestHandlerTest::NotifyRequestResult,
141 base::Unretained(this)))); 134 base::Unretained(this))));
142 } 135 }
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 delegate.reset(new TestAwPermissionRequestDelegate( 336 delegate.reset(new TestAwPermissionRequestDelegate(
344 origin_hostname, AwPermissionRequest::Geolocation, 337 origin_hostname, AwPermissionRequest::Geolocation,
345 base::Bind(&PermissionRequestHandlerTest::NotifyRequestResult, 338 base::Bind(&PermissionRequestHandlerTest::NotifyRequestResult,
346 base::Unretained(this)))); 339 base::Unretained(this))));
347 handler()->SendRequest(delegate.Pass()); 340 handler()->SendRequest(delegate.Pass());
348 EXPECT_TRUE(allowed()); 341 EXPECT_TRUE(allowed());
349 EXPECT_EQ(NULL, client()->request()); 342 EXPECT_EQ(NULL, client()->request());
350 } 343 }
351 344
352 } // android_webview 345 } // android_webview
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698