Issue 88703002: Add WARN_UNUSED_RESULT to DictionaryValue::GetXYZWithoutPathExpansion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 88703002: Add WARN_UNUSED_RESULT to DictionaryValue::GetXYZWithoutPathExpansion (Closed)

Created:
7 years ago by gab

Modified:
7 years ago

Reviewers:

CC:
chromium-reviews, erikwright+watch_chromium.org, Mattias Nissler (ping if slow), Bernhard Bauer, battre, Pam (message me for reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add WARN_UNUSED_RESULT to DictionaryValue::GetXYZWithoutPathExpansion BUG=323346

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -20 lines)			Patch
	M	base/values.h	View		1 chunk	+30 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

gab

FYI, I tried this after a discussion on https://codereview.chromium.org/81183005/ that this would be nice. Ideally ...

7 years ago (2013-11-26 19:27:23 UTC) #1

gab

7 years ago (2013-11-26 22:34:46 UTC) #2

On 2013/11/26 19:27:23, gab wrote:
> FYI, I tried this after a discussion on
> https://codereview.chromium.org/81183005/ that this would be nice.
> 
> Ideally I think all getters in values.h should probably force their users to
> check the return value of the getter.
> 
> This doesn't appear to be trivial however as it looks like some of the
failures
> are in third_party code depending on base :(...
> 
> Cheers!
> Gab

FYI, I think this would be a great improvement to the API, but I don't have time
to refactor everything required to make it happen.

I will close this CL, feel free to pick it up if you want.

Cheers,
Gab

Expand Messages | Collapse Messages