Add WARN_UNUSED_RESULT to DictionaryValue::GetXYZWithoutPathExpansion

base/values.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file specifies a recursive data storage class called Value intended for
 // storing settings and other persistable data.
 //
 // A Value represents something that can be stored in JSON or passed to/from
 // JavaScript. As such, it is NOT a generalized variant type, since only the
 // types supported by JavaScript/JSON are supported.
@@ skipping 270 matching lines @@
   bool GetBinary(const std::string& path, const BinaryValue** out_value) const;
   bool GetBinary(const std::string& path, BinaryValue** out_value);
   bool GetDictionary(const std::string& path,
                      const DictionaryValue** out_value) const;
   bool GetDictionary(const std::string& path, DictionaryValue** out_value);
   bool GetList(const std::string& path, const ListValue** out_value) const;
   bool GetList(const std::string& path, ListValue** out_value);
 
   // Like Get(), but without special treatment of '.'.  This allows e.g. URLs to
   // be used as paths.
-  bool GetWithoutPathExpansion(const std::string& key,
-                               const Value** out_value) const;
-  bool GetWithoutPathExpansion(const std::string& key, Value** out_value);
-  bool GetBooleanWithoutPathExpansion(const std::string& key,
-                                      bool* out_value) const;
-  bool GetIntegerWithoutPathExpansion(const std::string& key,
-                                      int* out_value) const;
-  bool GetDoubleWithoutPathExpansion(const std::string& key,
-                                     double* out_value) const;
-  bool GetStringWithoutPathExpansion(const std::string& key,
-                                     std::string* out_value) const;
-  bool GetStringWithoutPathExpansion(const std::string& key,
-                                     string16* out_value) const;
+  bool GetWithoutPathExpansion(
+      const std::string& key,
+      const Value** out_value) const WARN_UNUSED_RESULT;
+  bool GetWithoutPathExpansion(
+      const std::string& key, Value** out_value) WARN_UNUSED_RESULT;
+  bool GetBooleanWithoutPathExpansion(
+      const std::string& key,
+      bool* out_value) const WARN_UNUSED_RESULT;
+  bool GetIntegerWithoutPathExpansion(
+      const std::string& key,
+      int* out_value) const WARN_UNUSED_RESULT;
+  bool GetDoubleWithoutPathExpansion(
+      const std::string& key,
+      double* out_value) const WARN_UNUSED_RESULT;
+  bool GetStringWithoutPathExpansion(
+      const std::string& key,
+      std::string* out_value) const WARN_UNUSED_RESULT;
+  bool GetStringWithoutPathExpansion(
+      const std::string& key,
+      string16* out_value) const WARN_UNUSED_RESULT;
   bool GetDictionaryWithoutPathExpansion(
       const std::string& key,
-      const DictionaryValue** out_value) const;
-  bool GetDictionaryWithoutPathExpansion(const std::string& key,
-                                         DictionaryValue** out_value);
-  bool GetListWithoutPathExpansion(const std::string& key,
-                                   const ListValue** out_value) const;
-  bool GetListWithoutPathExpansion(const std::string& key,
-                                   ListValue** out_value);
+      const DictionaryValue** out_value) const WARN_UNUSED_RESULT;
+  bool GetDictionaryWithoutPathExpansion(
+      const std::string& key,
+      DictionaryValue** out_value) WARN_UNUSED_RESULT;
+  bool GetListWithoutPathExpansion(
+      const std::string& key,
+      const ListValue** out_value) const WARN_UNUSED_RESULT;
+  bool GetListWithoutPathExpansion(
+      const std::string& key,
+      ListValue** out_value) WARN_UNUSED_RESULT;
 
   // Removes the Value with the specified path from this dictionary (or one
   // of its child dictionaries, if the path is more than just a local key).
   // If |out_value| is non-NULL, the removed Value will be passed out via
   // |out_value|.  If |out_value| is NULL, the removed value will be deleted.
   // This method returns true if |path| is a valid path; otherwise it will
   // return false and the DictionaryValue object will be unchanged.
   virtual bool Remove(const std::string& path, scoped_ptr<Value>* out_value);
 
   // Like Remove(), but without special treatment of '.'.  This allows e.g. URLs
@@ skipping 204 matching lines @@
 
 }  // namespace base
 
 // http://crbug.com/88666
 using base::DictionaryValue;
 using base::ListValue;
 using base::StringValue;
 using base::Value;
 
 #endif  // BASE_VALUES_H_