Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1218)

Unified Diff: base/values.h

Issue 88703002: Add WARN_UNUSED_RESULT to DictionaryValue::GetXYZWithoutPathExpansion (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/values.h
diff --git a/base/values.h b/base/values.h
index bffdbc7d37eb2e38a87608518bda37d2b4726dbe..6baf7abce75d0c4dbc5fad9375e633f8295ed570 100644
--- a/base/values.h
+++ b/base/values.h
@@ -288,28 +288,38 @@ class BASE_EXPORT DictionaryValue : public Value {
// Like Get(), but without special treatment of '.'. This allows e.g. URLs to
// be used as paths.
- bool GetWithoutPathExpansion(const std::string& key,
- const Value** out_value) const;
- bool GetWithoutPathExpansion(const std::string& key, Value** out_value);
- bool GetBooleanWithoutPathExpansion(const std::string& key,
- bool* out_value) const;
- bool GetIntegerWithoutPathExpansion(const std::string& key,
- int* out_value) const;
- bool GetDoubleWithoutPathExpansion(const std::string& key,
- double* out_value) const;
- bool GetStringWithoutPathExpansion(const std::string& key,
- std::string* out_value) const;
- bool GetStringWithoutPathExpansion(const std::string& key,
- string16* out_value) const;
+ bool GetWithoutPathExpansion(
+ const std::string& key,
+ const Value** out_value) const WARN_UNUSED_RESULT;
+ bool GetWithoutPathExpansion(
+ const std::string& key, Value** out_value) WARN_UNUSED_RESULT;
+ bool GetBooleanWithoutPathExpansion(
+ const std::string& key,
+ bool* out_value) const WARN_UNUSED_RESULT;
+ bool GetIntegerWithoutPathExpansion(
+ const std::string& key,
+ int* out_value) const WARN_UNUSED_RESULT;
+ bool GetDoubleWithoutPathExpansion(
+ const std::string& key,
+ double* out_value) const WARN_UNUSED_RESULT;
+ bool GetStringWithoutPathExpansion(
+ const std::string& key,
+ std::string* out_value) const WARN_UNUSED_RESULT;
+ bool GetStringWithoutPathExpansion(
+ const std::string& key,
+ string16* out_value) const WARN_UNUSED_RESULT;
+ bool GetDictionaryWithoutPathExpansion(
+ const std::string& key,
+ const DictionaryValue** out_value) const WARN_UNUSED_RESULT;
bool GetDictionaryWithoutPathExpansion(
const std::string& key,
- const DictionaryValue** out_value) const;
- bool GetDictionaryWithoutPathExpansion(const std::string& key,
- DictionaryValue** out_value);
- bool GetListWithoutPathExpansion(const std::string& key,
- const ListValue** out_value) const;
- bool GetListWithoutPathExpansion(const std::string& key,
- ListValue** out_value);
+ DictionaryValue** out_value) WARN_UNUSED_RESULT;
+ bool GetListWithoutPathExpansion(
+ const std::string& key,
+ const ListValue** out_value) const WARN_UNUSED_RESULT;
+ bool GetListWithoutPathExpansion(
+ const std::string& key,
+ ListValue** out_value) WARN_UNUSED_RESULT;
// Removes the Value with the specified path from this dictionary (or one
// of its child dictionaries, if the path is more than just a local key).
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698