Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 887023003: Always emit bailout id for inlining property access (even for keyed access). (Closed)

Created:
5 years, 10 months ago by Jarin
Modified:
5 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev, danno
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Always emit bailout id for inlining property access (even for keyed access). R=ulan@chromium.org BUG=chromium:453805 LOG=n Committed: https://crrev.com/da90aabc072e2321f5902252e51ce0afadd3d76a Cr-Commit-Position: refs/heads/master@{#26359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -24 lines) Patch
M src/arm/full-codegen-arm.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-deoptimize-constant-keyed-load.js View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jarin
Could you take a look, please?
5 years, 10 months ago (2015-01-30 14:15:17 UTC) #1
ulan
LGTM!
5 years, 10 months ago (2015-01-30 14:18:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887023003/1
5 years, 10 months ago (2015-01-30 14:19:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 14:35:34 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 14:35:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da90aabc072e2321f5902252e51ce0afadd3d76a
Cr-Commit-Position: refs/heads/master@{#26359}

Powered by Google App Engine
This is Rietveld 408576698