Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Side by Side Diff: src/x87/full-codegen-x87.cc

Issue 887023003: Always emit bailout id for inlining property access (even for keyed access). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 2705 matching lines...) Expand 10 before | Expand all | Expand 10 after
2716 if (!expr->IsSuperAccess()) { 2716 if (!expr->IsSuperAccess()) {
2717 VisitForAccumulatorValue(expr->obj()); 2717 VisitForAccumulatorValue(expr->obj());
2718 __ Move(LoadDescriptor::ReceiverRegister(), result_register()); 2718 __ Move(LoadDescriptor::ReceiverRegister(), result_register());
2719 EmitNamedPropertyLoad(expr); 2719 EmitNamedPropertyLoad(expr);
2720 } else { 2720 } else {
2721 VisitForStackValue(expr->obj()->AsSuperReference()->this_var()); 2721 VisitForStackValue(expr->obj()->AsSuperReference()->this_var());
2722 EmitLoadHomeObject(expr->obj()->AsSuperReference()); 2722 EmitLoadHomeObject(expr->obj()->AsSuperReference());
2723 __ push(result_register()); 2723 __ push(result_register());
2724 EmitNamedSuperPropertyLoad(expr); 2724 EmitNamedSuperPropertyLoad(expr);
2725 } 2725 }
2726 PrepareForBailoutForId(expr->LoadId(), TOS_REG);
2727 context()->Plug(eax);
2728 } else { 2726 } else {
2729 if (!expr->IsSuperAccess()) { 2727 if (!expr->IsSuperAccess()) {
2730 VisitForStackValue(expr->obj()); 2728 VisitForStackValue(expr->obj());
2731 VisitForAccumulatorValue(expr->key()); 2729 VisitForAccumulatorValue(expr->key());
2732 __ pop(LoadDescriptor::ReceiverRegister()); // Object. 2730 __ pop(LoadDescriptor::ReceiverRegister()); // Object.
2733 __ Move(LoadDescriptor::NameRegister(), result_register()); // Key. 2731 __ Move(LoadDescriptor::NameRegister(), result_register()); // Key.
2734 EmitKeyedPropertyLoad(expr); 2732 EmitKeyedPropertyLoad(expr);
2735 } else { 2733 } else {
2736 VisitForStackValue(expr->obj()->AsSuperReference()->this_var()); 2734 VisitForStackValue(expr->obj()->AsSuperReference()->this_var());
2737 EmitLoadHomeObject(expr->obj()->AsSuperReference()); 2735 EmitLoadHomeObject(expr->obj()->AsSuperReference());
2738 __ push(result_register()); 2736 __ push(result_register());
2739 VisitForStackValue(expr->key()); 2737 VisitForStackValue(expr->key());
2740 EmitKeyedSuperPropertyLoad(expr); 2738 EmitKeyedSuperPropertyLoad(expr);
2741 } 2739 }
2742 context()->Plug(eax);
2743 } 2740 }
2741 PrepareForBailoutForId(expr->LoadId(), TOS_REG);
2742 context()->Plug(eax);
2744 } 2743 }
2745 2744
2746 2745
2747 void FullCodeGenerator::CallIC(Handle<Code> code, 2746 void FullCodeGenerator::CallIC(Handle<Code> code,
2748 TypeFeedbackId ast_id) { 2747 TypeFeedbackId ast_id) {
2749 ic_total_count_++; 2748 ic_total_count_++;
2750 __ call(code, RelocInfo::CODE_TARGET, ast_id); 2749 __ call(code, RelocInfo::CODE_TARGET, ast_id);
2751 } 2750 }
2752 2751
2753 2752
(...skipping 2462 matching lines...) Expand 10 before | Expand all | Expand 10 after
5216 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5215 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5217 Assembler::target_address_at(call_target_address, 5216 Assembler::target_address_at(call_target_address,
5218 unoptimized_code)); 5217 unoptimized_code));
5219 return OSR_AFTER_STACK_CHECK; 5218 return OSR_AFTER_STACK_CHECK;
5220 } 5219 }
5221 5220
5222 5221
5223 } } // namespace v8::internal 5222 } } // namespace v8::internal
5224 5223
5225 #endif // V8_TARGET_ARCH_X87 5224 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | test/mjsunit/regress/regress-deoptimize-constant-keyed-load.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698