Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 887023003: Always emit bailout id for inlining property access (even for keyed access). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 2718 matching lines...) Expand 10 before | Expand all | Expand 10 after
2729 if (!expr->IsSuperAccess()) { 2729 if (!expr->IsSuperAccess()) {
2730 VisitForAccumulatorValue(expr->obj()); 2730 VisitForAccumulatorValue(expr->obj());
2731 __ Move(LoadDescriptor::ReceiverRegister(), result_register()); 2731 __ Move(LoadDescriptor::ReceiverRegister(), result_register());
2732 EmitNamedPropertyLoad(expr); 2732 EmitNamedPropertyLoad(expr);
2733 } else { 2733 } else {
2734 VisitForStackValue(expr->obj()->AsSuperReference()->this_var()); 2734 VisitForStackValue(expr->obj()->AsSuperReference()->this_var());
2735 EmitLoadHomeObject(expr->obj()->AsSuperReference()); 2735 EmitLoadHomeObject(expr->obj()->AsSuperReference());
2736 __ push(result_register()); 2736 __ push(result_register());
2737 EmitNamedSuperPropertyLoad(expr); 2737 EmitNamedSuperPropertyLoad(expr);
2738 } 2738 }
2739 PrepareForBailoutForId(expr->LoadId(), TOS_REG);
2740 context()->Plug(eax);
2741 } else { 2739 } else {
2742 if (!expr->IsSuperAccess()) { 2740 if (!expr->IsSuperAccess()) {
2743 VisitForStackValue(expr->obj()); 2741 VisitForStackValue(expr->obj());
2744 VisitForAccumulatorValue(expr->key()); 2742 VisitForAccumulatorValue(expr->key());
2745 __ pop(LoadDescriptor::ReceiverRegister()); // Object. 2743 __ pop(LoadDescriptor::ReceiverRegister()); // Object.
2746 __ Move(LoadDescriptor::NameRegister(), result_register()); // Key. 2744 __ Move(LoadDescriptor::NameRegister(), result_register()); // Key.
2747 EmitKeyedPropertyLoad(expr); 2745 EmitKeyedPropertyLoad(expr);
2748 } else { 2746 } else {
2749 VisitForStackValue(expr->obj()->AsSuperReference()->this_var()); 2747 VisitForStackValue(expr->obj()->AsSuperReference()->this_var());
2750 EmitLoadHomeObject(expr->obj()->AsSuperReference()); 2748 EmitLoadHomeObject(expr->obj()->AsSuperReference());
2751 __ push(result_register()); 2749 __ push(result_register());
2752 VisitForStackValue(expr->key()); 2750 VisitForStackValue(expr->key());
2753 EmitKeyedSuperPropertyLoad(expr); 2751 EmitKeyedSuperPropertyLoad(expr);
2754 } 2752 }
2755 context()->Plug(eax);
2756 } 2753 }
2754 PrepareForBailoutForId(expr->LoadId(), TOS_REG);
2755 context()->Plug(eax);
2757 } 2756 }
2758 2757
2759 2758
2760 void FullCodeGenerator::CallIC(Handle<Code> code, 2759 void FullCodeGenerator::CallIC(Handle<Code> code,
2761 TypeFeedbackId ast_id) { 2760 TypeFeedbackId ast_id) {
2762 ic_total_count_++; 2761 ic_total_count_++;
2763 __ call(code, RelocInfo::CODE_TARGET, ast_id); 2762 __ call(code, RelocInfo::CODE_TARGET, ast_id);
2764 } 2763 }
2765 2764
2766 2765
(...skipping 2510 matching lines...) Expand 10 before | Expand all | Expand 10 after
5277 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5276 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5278 Assembler::target_address_at(call_target_address, 5277 Assembler::target_address_at(call_target_address,
5279 unoptimized_code)); 5278 unoptimized_code));
5280 return OSR_AFTER_STACK_CHECK; 5279 return OSR_AFTER_STACK_CHECK;
5281 } 5280 }
5282 5281
5283 5282
5284 } } // namespace v8::internal 5283 } } // namespace v8::internal
5285 5284
5286 #endif // V8_TARGET_ARCH_IA32 5285 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698