Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 887023003: Always emit bailout id for inlining property access (even for keyed access). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 2793 matching lines...) Expand 10 before | Expand all | Expand 10 after
2804 if (!expr->IsSuperAccess()) { 2804 if (!expr->IsSuperAccess()) {
2805 VisitForAccumulatorValue(expr->obj()); 2805 VisitForAccumulatorValue(expr->obj());
2806 __ Move(LoadDescriptor::ReceiverRegister(), v0); 2806 __ Move(LoadDescriptor::ReceiverRegister(), v0);
2807 EmitNamedPropertyLoad(expr); 2807 EmitNamedPropertyLoad(expr);
2808 } else { 2808 } else {
2809 VisitForStackValue(expr->obj()->AsSuperReference()->this_var()); 2809 VisitForStackValue(expr->obj()->AsSuperReference()->this_var());
2810 EmitLoadHomeObject(expr->obj()->AsSuperReference()); 2810 EmitLoadHomeObject(expr->obj()->AsSuperReference());
2811 __ Push(result_register()); 2811 __ Push(result_register());
2812 EmitNamedSuperPropertyLoad(expr); 2812 EmitNamedSuperPropertyLoad(expr);
2813 } 2813 }
2814 PrepareForBailoutForId(expr->LoadId(), TOS_REG);
2815 context()->Plug(v0);
2816 } else { 2814 } else {
2817 if (!expr->IsSuperAccess()) { 2815 if (!expr->IsSuperAccess()) {
2818 VisitForStackValue(expr->obj()); 2816 VisitForStackValue(expr->obj());
2819 VisitForAccumulatorValue(expr->key()); 2817 VisitForAccumulatorValue(expr->key());
2820 __ Move(LoadDescriptor::NameRegister(), v0); 2818 __ Move(LoadDescriptor::NameRegister(), v0);
2821 __ pop(LoadDescriptor::ReceiverRegister()); 2819 __ pop(LoadDescriptor::ReceiverRegister());
2822 EmitKeyedPropertyLoad(expr); 2820 EmitKeyedPropertyLoad(expr);
2823 } else { 2821 } else {
2824 VisitForStackValue(expr->obj()->AsSuperReference()->this_var()); 2822 VisitForStackValue(expr->obj()->AsSuperReference()->this_var());
2825 EmitLoadHomeObject(expr->obj()->AsSuperReference()); 2823 EmitLoadHomeObject(expr->obj()->AsSuperReference());
2826 __ Push(result_register()); 2824 __ Push(result_register());
2827 VisitForStackValue(expr->key()); 2825 VisitForStackValue(expr->key());
2828 EmitKeyedSuperPropertyLoad(expr); 2826 EmitKeyedSuperPropertyLoad(expr);
2829 } 2827 }
2830 context()->Plug(v0);
2831 } 2828 }
2829 PrepareForBailoutForId(expr->LoadId(), TOS_REG);
2830 context()->Plug(v0);
2832 } 2831 }
2833 2832
2834 2833
2835 void FullCodeGenerator::CallIC(Handle<Code> code, 2834 void FullCodeGenerator::CallIC(Handle<Code> code,
2836 TypeFeedbackId id) { 2835 TypeFeedbackId id) {
2837 ic_total_count_++; 2836 ic_total_count_++;
2838 __ Call(code, RelocInfo::CODE_TARGET, id); 2837 __ Call(code, RelocInfo::CODE_TARGET, id);
2839 } 2838 }
2840 2839
2841 2840
(...skipping 2502 matching lines...) Expand 10 before | Expand all | Expand 10 after
5344 Assembler::target_address_at(pc_immediate_load_address)) == 5343 Assembler::target_address_at(pc_immediate_load_address)) ==
5345 reinterpret_cast<uint32_t>( 5344 reinterpret_cast<uint32_t>(
5346 isolate->builtins()->OsrAfterStackCheck()->entry())); 5345 isolate->builtins()->OsrAfterStackCheck()->entry()));
5347 return OSR_AFTER_STACK_CHECK; 5346 return OSR_AFTER_STACK_CHECK;
5348 } 5347 }
5349 5348
5350 5349
5351 } } // namespace v8::internal 5350 } } // namespace v8::internal
5352 5351
5353 #endif // V8_TARGET_ARCH_MIPS 5352 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698