Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 885813002: Minor refactoring for Zone class and friends. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Minor refactoring for Zone class and friends. R=svenpanne@chromium.org Committed: https://crrev.com/d0f3e5302c8d89fee4995b86a2b83c9ecf5d1e7a Cr-Commit-Position: refs/heads/master@{#26315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -163 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/bit-vector.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interface.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/jsregexp.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/profile-generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/safepoint-table.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/scopeinfo.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/type-info.h View 1 chunk +1 line, -1 line 0 comments Download
M src/v8.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/zone.h View 10 chunks +47 lines, -37 lines 0 comments Download
M src/zone.cc View 14 chunks +59 lines, -41 lines 0 comments Download
D src/zone-inl.h View 1 chunk +0 lines, -70 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 10 months ago (2015-01-29 06:13:02 UTC) #1
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-01-29 06:13:22 UTC) #2
Sven Panne
lgtm
5 years, 10 months ago (2015-01-29 07:38:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885813002/1
5 years, 10 months ago (2015-01-29 07:39:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 07:41:43 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 07:42:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0f3e5302c8d89fee4995b86a2b83c9ecf5d1e7a
Cr-Commit-Position: refs/heads/master@{#26315}

Powered by Google App Engine
This is Rietveld 408576698