Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 885713004: Remove CustomElementDescriptor. (Closed)

Created:
5 years, 10 months ago by esprehn
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove CustomElementDescriptor. In Sky we only need the localName of an element to describe what it is. Remove this abstraction which is just a thin wrapper around AtomicString. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a67063b1759b260ba6b6858e39a3bf9994ec168e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -197 lines) Patch
M sky/engine/bindings/core/v8/CustomElementConstructorBuilder.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementDefinition.h View 1 chunk +5 lines, -5 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementDefinition.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
D sky/engine/core/dom/custom/CustomElementDescriptor.h View 1 chunk +0 lines, -84 lines 0 comments Download
D sky/engine/core/dom/custom/CustomElementDescriptorHash.h View 1 chunk +0 lines, -66 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementMicrotaskResolutionStep.h View 2 chunks +2 lines, -4 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementRegistrationContext.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementRegistrationContext.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementRegistry.h View 2 chunks +2 lines, -4 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementRegistry.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementScheduler.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementScheduler.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 10 months ago (2015-01-29 04:42:27 UTC) #2
esprehn
5 years, 10 months ago (2015-01-29 04:46:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a67063b1759b260ba6b6858e39a3bf9994ec168e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698