sky/engine/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp - Issue 885713004: Remove CustomElementDescriptor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp

Issue 885713004: Remove CustomElementDescriptor. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sky/engine/core/dom/custom/CustomElementMicrotaskResolutionStep.h ('k') | sky/engine/core/dom/custom/CustomElementRegistrationContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/engine/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp

diff --git a/sky/engine/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp b/sky/engine/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp

index 52452c1c111d528cc3ecda93459a70c5d245a008..e15a2dc5169c04d3ed2832d08975407d5e65c870 100644

--- a/sky/engine/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp

+++ b/sky/engine/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp

@@ -36,15 +36,14 @@

namespace blink {

-PassOwnPtr<CustomElementMicrotaskResolutionStep> CustomElementMicrotaskResolutionStep::create(PassRefPtr<CustomElementRegistrationContext> context, PassRefPtr<Element> element, const CustomElementDescriptor& descriptor)

+PassOwnPtr<CustomElementMicrotaskResolutionStep> CustomElementMicrotaskResolutionStep::create(PassRefPtr<CustomElementRegistrationContext> context, PassRefPtr<Element> element)

{

- return adoptPtr(new CustomElementMicrotaskResolutionStep(context, element, descriptor));

+ return adoptPtr(new CustomElementMicrotaskResolutionStep(context, element));

}

-CustomElementMicrotaskResolutionStep::CustomElementMicrotaskResolutionStep(PassRefPtr<CustomElementRegistrationContext> context, PassRefPtr<Element> element, const CustomElementDescriptor& descriptor)

+CustomElementMicrotaskResolutionStep::CustomElementMicrotaskResolutionStep(PassRefPtr<CustomElementRegistrationContext> context, PassRefPtr<Element> element)

: m_context(context)

, m_element(element)

- , m_descriptor(descriptor)

{

}

@@ -54,7 +53,7 @@ CustomElementMicrotaskResolutionStep::~CustomElementMicrotaskResolutionStep()

CustomElementMicrotaskStep::Result CustomElementMicrotaskResolutionStep::process()

{

- m_context->resolve(m_element.get(), m_descriptor);

+ m_context->resolve(m_element.get());

return CustomElementMicrotaskStep::FinishedProcessing;

}